Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chip] Fix color contrast against default dark background #9501

Merged
merged 1 commit into from
Dec 15, 2017
Merged

[Chip] Fix color contrast against default dark background #9501

merged 1 commit into from
Dec 15, 2017

Conversation

mbrookes
Copy link
Member

Closes #9407

@mbrookes mbrookes mentioned this pull request Dec 14, 2017
Closed
1 task
@oliviertassinari oliviertassinari merged commit 58b2521 into mui:v1-beta Dec 15, 2017
@mbrookes
Copy link
Member Author

Hmm... just realised this is going to be problematic against a dark paper background (also grey[800]).

Running out of ideas here...

@oliviertassinari
Copy link
Member

I was suggesting 700 in the issue.

@mbrookes
Copy link
Member Author

As mentioned in the issue, 700 doesn't contrast with dark avatar.

@oliviertassinari
Copy link
Member

@mbrookes It's a tradeoff then. We can pick what's more important 😬 .

@mbrookes mbrookes deleted the chip-fix-color branch January 20, 2018 22:38
@zannager zannager added the component: chip This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: chip This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbrookes @oliviertassinari @zannager