-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chip] Bad color contrast when using the dark theme #9407
Comments
Changing the approach to a background color using
|
@oliviertassinari Can I create the pull request?. |
Because the chip bacground is a mid-grey, it might be possible to simplify things considerably by having Chip not change color for the dark theme. The spec doesn't show a dark variant. |
Just to add my 2 cents - grayish clickable/deletable hover/focus/active styles should be easier to customize/override. For example if you have chips in various colors and want to remove grayish clickable/deletable hover/focus/active styles while retaining base chip color the same how would you do it? |
@vladimirpekez It can easily be done with the override API. Feel free to open a question on StackOverflow if needed. |
@oliviertassinari Done: https://stackoverflow.com/questions/47817109/how-to-eliminate-hover-active-focus-gray-color-in-material-ui-chip-component. Colleague at our team who needed to eliminate grey hover/active style ended up with several chips components, each created to override certain color - there has to be a better way ;) |
This wasn't practical, as our implementation of Avatar has a dark theme. Changing Chip to a mono-theme would have meant changing both. Much as we want to avoid component specific colors in the theme, I've gone with @oliviertassinari's solution in #9501. That at least makes it easier to have a custom chip color while having hover & focus colors match. I had to use |
@vladimirpekez Seems like a good opportunity for the factory pattern. We can continue this discussion on StackOverflow. |
This issue is actual. |
It seems we have reached a dead end #9501 (comment). |
Expected Behavior
I want more color contrast when using the dark theme
Current Behavior
Bad color contrast when using the Chip component with the dark theme
Steps to Reproduce (for bugs)
You may see this on example
You may see how different color contrasts are in light and dark themes
Context
I want that visualization of my dark application is good
Your Environment
The text was updated successfully, but these errors were encountered: