[code-infra] Run react-17 and react-next workflows on the next branch
#42690
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,7 +108,16 @@ commands: | |
| pnpm --version | ||
| - run: | ||
| name: Install js dependencies | ||
| command: | | ||
| echo "React version $REACT_VERSION" | ||
| if [[ $(git --no-pager diff HEAD) == "" ]]; | ||
| then | ||
| echo "pnpm install" | ||
| pnpm install | ||
| else | ||
| echo "pnpm install --no-frozen-lockfile" | ||
| pnpm install --no-frozen-lockfile | ||
| fi | ||
| - when: | ||
| condition: << parameters.browsers >> | ||
| steps: | ||
|
|
@@ -887,48 +896,106 @@ workflows: | |
| jobs: | ||
| - test_profile: | ||
| <<: *default-context | ||
|
|
||
| # This workflow can be triggered manually on the PR | ||
| react-17: | ||
| when: | ||
| equal: [react-17, << pipeline.parameters.workflow >>] | ||
| jobs: | ||
|
There was a problem hiding this comment. I had to duplicate the jobs here, I couldn't find a way to reuse them in CircleCI (the experience of configuring Circle CI is not great TBH 😅). The whole point is that: There was a problem hiding this comment. Yeah, it's not great. Perhaps an orb could fix duplication here, but I don't really mind it so much. |
||
| - test_unit: | ||
| <<: *default-context | ||
| react-version: ^17.0.0 | ||
| name: test_unit-react@17 | ||
| - test_browser: | ||
| <<: *default-context | ||
| react-version: ^17.0.0 | ||
| name: test_browser-react@17 | ||
| - test_regressions: | ||
| <<: *default-context | ||
| react-version: ^17.0.0 | ||
| name: test_regressions-react@17 | ||
| - test_e2e: | ||
| <<: *default-context | ||
| react-version: ^17.0.0 | ||
| name: test_e2e-react@17 | ||
|
|
||
| # This workflow is identical to react-17, but scheduled | ||
| react-17-cron: | ||
| triggers: | ||
| - schedule: | ||
| cron: '0 0 * * *' | ||
| filters: | ||
| branches: | ||
| only: | ||
| - master | ||
| - next | ||
| jobs: | ||
| - test_unit: | ||
| <<: *default-context | ||
| react-version: ^17.0.0 | ||
| name: test_unit-react@17 | ||
| - test_browser: | ||
| <<: *default-context | ||
| react-version: ^17.0.0 | ||
| name: test_browser-react@17 | ||
| - test_regressions: | ||
| <<: *default-context | ||
| react-version: ^17.0.0 | ||
| name: test_regressions-react@17 | ||
| - test_e2e: | ||
| <<: *default-context | ||
| react-version: ^17.0.0 | ||
| name: test_e2e-react@17 | ||
|
|
||
| # This workflow can be triggered manually on the PR | ||
| react-next: | ||
| when: | ||
| equal: [react-next, << pipeline.parameters.workflow >>] | ||
| jobs: | ||
| - test_unit: | ||
| <<: *default-context | ||
| react-version: next | ||
| name: test_unit-react@next | ||
|
There was a problem hiding this comment. Added names here to avoid confusing job names, like this: 
There was a problem hiding this comment. I'm not sure why these ghost jobs appear though: 
Perhaps it's a lag on the CircleCI side. There was a problem hiding this comment. Maybe it got in a bad state after renaming those jobs? Maybe try opening a different PR? There was a problem hiding this comment. Tried in #42991 and the result is the same... There was a problem hiding this comment. I believe circleci reuses some existing state when opening a PR for the same commit. At least I think I've observed that before. Trying out that hypothesis in mui/mui-x#13942 There was a problem hiding this comment. Thanks, that seems to work! There was a problem hiding this comment. All looks good now! |
||
| - test_browser: | ||
| <<: *default-context | ||
| react-version: next | ||
| name: test_browser-react@next | ||
| - test_regressions: | ||
| <<: *default-context | ||
| react-version: next | ||
| name: test_regressions-react@next | ||
| - test_e2e: | ||
| <<: *default-context | ||
| react-version: next | ||
| name: test_e2e-react@next | ||
| # This workflow is identical to react-next, but scheduled | ||
| react-next-cron: | ||
| triggers: | ||
| - schedule: | ||
| cron: '0 0 * * *' | ||
| filters: | ||
| branches: | ||
| only: | ||
| - master | ||
| - next | ||
| jobs: | ||
| - test_unit: | ||
| <<: *default-context | ||
| react-version: next | ||
| name: test_unit-react@next | ||
| - test_browser: | ||
| <<: *default-context | ||
| react-version: next | ||
| name: test_browser-react@next | ||
| - test_regressions: | ||
| <<: *default-context | ||
| react-version: next | ||
| name: test_regressions-react@next | ||
| - test_e2e: | ||
| <<: *default-context | ||
| react-version: next | ||
| name: test_e2e-react@next | ||
|
|
||
| typescript-next: | ||
| triggers: | ||
| - schedule: | ||
|
|
@@ -937,6 +1004,7 @@ workflows: | |
| branches: | ||
| only: | ||
| - master | ||
| - next | ||
|
There was a problem hiding this comment. Added |
||
| jobs: | ||
| - test_types_next: | ||
| <<: *default-context | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
useReactVersionscript modifiesresolutionsinpackage.json, and it can't install dependencies without this flag.If there were no changes done to package.json (
git --no-pager diff HEAD) == ""), the flag is not being passed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense for the
useReactVersionscript to runpnpm installafter it sets the resolutions? That would make the lockfile consistent with what's installed and this branching becomes unnecessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, running
useReactVersionwithout installing the dependencies does not make much sense anyway 👍🏻