Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui][joy-ui][Autocomplete] Fix Hint demo #42990

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

ManthanGajjar
Copy link
Contributor

@ManthanGajjar ManthanGajjar commented Jul 18, 2024

Fixes #42882

Preview: https://deploy-preview-42990--material-ui.netlify.app/material-ui/react-autocomplete/#hint

Issue description

the dropdown does not show the selected option after clicking on it

Before:

Screen.Recording.2024-07-18.at.3.38.22.PM.mov

After:

Screen.Recording.2024-07-18.at.3.38.41.PM.mov

@ManthanGajjar ManthanGajjar marked this pull request as draft July 18, 2024 10:12
@mui-bot
Copy link

mui-bot commented Jul 18, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 581074e

@ManthanGajjar ManthanGajjar reopened this Jul 18, 2024
@ManthanGajjar ManthanGajjar reopened this Jul 18, 2024
@ManthanGajjar ManthanGajjar marked this pull request as ready for review July 18, 2024 10:29
@ManthanGajjar
Copy link
Contributor Author

Not able to add / update labels in this PR :(

@zannager zannager added the component: autocomplete This is the name of the generic UI component, not the React module! label Jul 18, 2024
@zannager zannager requested a review from sai6855 July 18, 2024 13:22
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Jul 21, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material] fix autocomplete hint issue [docs][material-ui][Autocomplete] Fix Hint demo Jul 21, 2024
@ZeeshanTamboli ZeeshanTamboli added the regression A bug, but worse label Jul 21, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix works well for selecting option from Autocomplete but I found other issues as well. See screen recording:

issue-42990.mp4

@ZeeshanTamboli ZeeshanTamboli added the package: joy-ui Specific to @mui/joy label Jul 23, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui][Autocomplete] Fix Hint demo [docs][material-ui][joy-ui][Autocomplete] Fix Hint demo Jul 23, 2024
@ZeeshanTamboli ZeeshanTamboli added the needs cherry-pick The PR should be cherry-picked to master after merge label Jul 23, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the overflowing hint text and also made sure that the hint text is cleared when a option as selected. Rest looks good. @ManthanGajjar Thanks for the pull request.

@ZeeshanTamboli ZeeshanTamboli merged commit 64a093a into mui:next Jul 23, 2024
19 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge package: joy-ui Specific to @mui/joy package: material-ui Specific to @mui/material regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs][material-ui][Autocomplete] Hint demo is broken
4 participants