Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Remove Pigment CSS examples #42471

Merged
merged 2 commits into from
Jun 5, 2024
Merged

[examples] Remove Pigment CSS examples #42471

merged 2 commits into from
Jun 5, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Jun 1, 2024 •
edited by oliviertassinari
Loading

As mentioned here #42160 (comment) , this PR removes pigment-css related examples from this repository

Not sure about argos failure, don't think it's related to this PR

Closes mui/pigment-css#61

@sai6855 sai6855 added examples Relating to /examples package: pigment-css Specific to @pigment-css/* labels Jun 1, 2024
@mui-bot
Copy link

mui-bot commented Jun 1, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42471--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4829d2c

@sai6855 sai6855 changed the title [pigment-css][css] Remove pigment-css examples from material-ui repository [pigment-css][examples] Remove pigment-css examples from material-ui repository Jun 1, 2024
@sai6855 sai6855 mentioned this pull request Jun 1, 2024
Merged
1 task
@oliviertassinari
Copy link
Member

Not sure about argos failure, don't think it's related to this PR

Reported in #41757 (comment)

@oliviertassinari oliviertassinari mentioned this pull request Jun 1, 2024
Merged
1 task
ZeeshanTamboli
ZeeshanTamboli reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this?

@sai6855
Copy link
Contributor Author

sai6855 commented Jun 5, 2024

What do you think about this?

Ah okay, let's wait for decision then

@ZeeshanTamboli ZeeshanTamboli changed the title [pigment-css][examples] Remove pigment-css examples from material-ui repository [examples] Remove Pigment CSS examples Jun 5, 2024
@ZeeshanTamboli ZeeshanTamboli removed the package: pigment-css Specific to @pigment-css/* label Jun 5, 2024
@ZeeshanTamboli
Copy link
Member

What do you think about this?

Ah okay, let's wait for decision then

I think that can be addressed separately. Having these framework examples without any usage of @mui/* packages doesn't make sense for this repository.

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Jun 5, 2024 •
edited
Loading

@sai6855 Could you remove it from the master branch as well in a separate PR? See https://github.com/mui/material-ui/tree/master/examples. The /examples link in this documentation redirects to the master branch.

@ZeeshanTamboli ZeeshanTamboli merged commit 8f45c8e into mui:next Jun 5, 2024
20 checks passed
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@sai6855 @joserodolfofreitas
[examples] Remove Pigment CSS examples (mui#42471)
69743b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@brijeshb42 brijeshb42 Awaiting requested review from brijeshb42

@danilo-leal danilo-leal Awaiting requested review from danilo-leal

Assignees
No one assigned
Labels
examples Relating to /examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[examples] Migrate examples from Material UI
4 participants
@sai6855 @mui-bot @oliviertassinari @ZeeshanTamboli