Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Migrate examples from Material UI #61

Open
oliviertassinari opened this issue May 8, 2024 · 2 comments · Fixed by mui/material-ui#42471
Open

[examples] Migrate examples from Material UI #61

oliviertassinari opened this issue May 8, 2024 · 2 comments · Fixed by mui/material-ui#42471
Assignees
Labels
bug 🐛 Something doesn't work examples Relating to /examples

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented May 8, 2024

Steps to reproduce

No response

Current behavior

No examples folder here, and examples folders in Material UI.

Expected behavior

Examples folder here, and no examples folders in Material UI.

Context

mui/material-ui#42160 (comment)

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: -

@mnajdova
Copy link
Member

mnajdova commented Jun 3, 2024

Agree on moving the Pigment CSS examples, but instead of removing the one from Material UI, can we repurpose them on how to set up Material UI with Pigment CSS and popular frameworks? This will be important when v6 is released.

@ZeeshanTamboli ZeeshanTamboli removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 5, 2024
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jun 5, 2024

@mnajdova Great idea. Reopening:

The only counter-argument is that; the sooner we can make Pigment CSS the default what to use Material UI, the better. At which point, we would have the opposite a /examples/material-ui-vite-emotion example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work examples Relating to /examples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants