[AutoComplete] Fix first item selection on keyboard focus

[viniciusdacal]

This fix first item selection at autocomplete popover, described at #3629.
If you type 'a' in the input, and hit down arrow to select the first item, you don't see the selection, if you press again, the second item will be selected.
http://www.material-ui.com/#/components/auto-complete

Fixes #3629.

[mbrookes]

Thanks for recreating the PR.

[oliviertassinari]

@viniciusdacal I haven't noticed any issue with the component. That looks good 👍.

[oliviertassinari]

What if nextProps.keyboardFocused = false and this.state.isKeyboardFocused = true 😁?

[viniciusdacal]

Good question 😄
Do you think we could use only nextProps.keyboardFocused here?

[oliviertassinari]

We could use something like:

isKeyboardFocused: nextProps.keyboardFocused !== null ? nextProps.keyboardFocused : this.state.isKeyboardFocused

[viniciusdacal]

@oliviertassinari pr updated.

[oliviertassinari]

@viniciusdacal Thanks.
Looking at the initial state of isKeyboardFocused we can see that it's set by the props.initiallyKeyboardFocused. Should we use keyboardFocused first and fallback to initiallyKeyboardFocused if it's null?

[viniciusdacal]

@oliviertassinari make sense for me use keyboardFocused first, the api would be more consistent. Do you want me to change it?

[oliviertassinari]

@viniciusdacal Yes please 👯.

[viniciusdacal]

Great.
I can work on this tonight (in 6 hours), I don't have the environment installed here.

[oliviertassinari]

Don't worry, no need to rush things :).

On Thu, 7 Apr 2016 19:22 Vinicius Dacal Lopes, notifications@github.com
wrote:

Great.
I can work on this tonight (in 6 hours), I don't have the environment
installed here.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#3867 (comment)

[viniciusdacal]

@oliviertassinari updated 😄

[nathanmarks]

Unless I'm missing something -- can that be shortened to props.keyboardFocused || props.initiallyKeyboardFocused

[viniciusdacal]

if we set prop keyboardFocused as false, isKeyboardFocused should be false, even if initiallyKeyboardFocused is true

[oliviertassinari]

@viniciusdacal I have just realized that we can fix the issue with a single line diff commit:

-initiallyKeyboardFocused={false}
+initiallyKeyboardFocused={true}

No need for an extra keyboardFocused property. Can you check that and update the PR if it's working fine 😁?

[viniciusdacal]

@oliviertassinari I will change to check, but I think this way it will be focused instantly when the menu open, and not only on keydown.

[mbrookes]

@viniciusdacal - what did you find?

[viniciusdacal]

@mbrookes I was very busy in the last weeks, but I'm gonna use this weekend to solve this.

[mbrookes]

On hold pending review of alternate fix.