Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoComplete] focus first item when cursor down key pressed #3791

Closed
wants to merge 1 commit into from

Conversation

jootse84
Copy link

Autocomplete does not focus first item when press down arrow key (#2596). This PR solves it by using a new property keyboardFocused on Menu component.

Closes #2596.

@mbrookes mbrookes added PR: Needs Review PR: out-of-date The pull request has merge conflicts and can't be merged labels Mar 24, 2016
@oliviertassinari
Copy link
Member

Similar to #3674.

@jootse84
Copy link
Author

That fixed the issue long time ago, I forgot the pull-request.
If @viniciusdacal is interested he can take a look and fix the bug, if not I can try to do it by myself.

@mbrookes mbrookes added the bug 🐛 Something doesn't work label Mar 28, 2016
@mbrookes
Copy link
Member

mbrookes commented Apr 2, 2016

@jootse84 - @viniciusdacal closed #3674. All yours!

@viniciusdacal
Copy link

@mbrookes, I had to, when I did a rebase I lost everything, sorry 😢
I also felt a little confused, I think the docs are not updated, there is no command
npm run browser:development at package.json anymore.

@mbrookes
Copy link
Member

mbrookes commented Apr 2, 2016

A rebase won't lose everything, even if it goes wrong. 👍

You could git rebase --abort or if it's beyond that you could find your commits in get reflog and cherry-pick, or git reset --HARD <some ref before your commits> then git pull origin to get it back from github.

For rebasing - renaming the files first will help a bit, although with the new structure for ES6 classes, you might just find it easier to update from HEAD, and apply your changes manually: https://github.com/callemall/material-ui/pull/3791/files

Regarding the docs:

npm start (aka npm run browser:development) is in the docs directory package.json.

@mbrookes mbrookes changed the title [AutoComplete] focus when arror down #2596 [AutoComplete] focus first item when cursor down key pressed Apr 2, 2016
@viniciusdacal
Copy link

@mbrookes completely my bad.
Thanks for the help with git and the docs, in my daily job we don't use rebase, so I'm not used with the command.
I recreated the branch and I sent a new PR, #3867

@mbrookes
Copy link
Member

mbrookes commented Apr 3, 2016

Closing in favour of #3867.

@mbrookes mbrookes closed this Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants