Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Clarify Hidden down props as exclusive #36927

Merged
merged 4 commits into from
May 29, 2023

Conversation

canac
Copy link
Contributor

@canac canac commented Apr 18, 2023

Fixes #36657

@mui-bot
Copy link

mui-bot commented Apr 18, 2023

Netlify deploy preview

https://deploy-preview-36927--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 10f332e

@zannager zannager added docs Improvements or additions to the documentation component: Hidden The React component. labels Apr 19, 2023
@zannager zannager requested a review from siriwatknp April 19, 2023 06:20
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label May 29, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I fixed the function comment in 10f332e. I'm not sure why the inclusive parameter is included in these methods if it's not used anywhere.

Please note that the Hidden component is deprecated.

@ZeeshanTamboli ZeeshanTamboli merged commit a6c93af into mui:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: Hidden The React component. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Hidden down props should be exclusive not inclusive
4 participants