Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Hidden down props should be exclusive not inclusive #36657

Closed
1 task done
canac opened this issue Mar 27, 2023 · 2 comments · Fixed by #36927
Closed
1 task done

[docs] Hidden down props should be exclusive not inclusive #36657

canac opened this issue Mar 27, 2023 · 2 comments · Fixed by #36927
Assignees
@siriwatknp
Labels
bug 🐛 Something doesn't work component: Hidden The React component. docs Improvements or additions to the documentation

Comments

@canac
Copy link
Contributor

canac commented Mar 27, 2023

Duplicates

  • I have searched the existing issues

Related page

https://mui.com/material-ui/api/hidden/

Kind of issue

Other

Issue description

The docs for <Hidden /> say that the down props hide the element at "this size and down". However, the code shows that it only hides the element below this size (i.e. the docs say inclusive and the code says exclusive).

Context 🔦

No response
@canac canac added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Mar 27, 2023
@zannager zannager added the component: Hidden The React component. label Mar 27, 2023
@siriwatknp siriwatknp removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 14, 2023
@siriwatknp
Copy link
Member

Do you want to submit a PR that fixes this?

@canac canac mentioned this issue Apr 18, 2023
Merged
1 task
@canac
Copy link
Contributor Author

canac commented Apr 18, 2023

@siriwatknp Sure! Feel free to wordsmith if desired.

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work docs Improvements or additions to the documentation and removed support: docs-feedback Feedback from documentation page labels May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siriwatknp siriwatknp

Labels
bug 🐛 Something doesn't work component: Hidden The React component. docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Clarify Hidden down props as exclusive canac/material-ui
4 participants
@canac @siriwatknp @ZeeshanTamboli @zannager