Utilize cancellation over isMounted for indicators #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
| @@ -16,7 +16,7 @@ const ProgressPage = React.createClass({ | |||
| componentDidMount() { | |||
| let self = this; | |||
|
|
|||
| let id = window.setInterval(() => { | |||
| this.timer = window.setInterval(() => { | |||
There was a problem hiding this comment.
What about adding it at the top like here https://github.com/callemall/material-ui/blob/master/src/snackbar.jsx#L24?
There was a problem hiding this comment.
Yes!! Definitely, great idea. I'll get done, thanks 👍 👍
|
@oliviertassinari Take another look. |
That's why |
alitaheri
force-pushed
the
fix-progress-timer-leak
branch
from
8d492e1 to
243c9ff
Compare
|
@oliviertassinari Merge this if all is good. |
|
@alitaheri That also remove a warning in the doc page. Nice work 👍. |
oliviertassinari
added a commit
that referenced
this pull request
Dec 31, 2015
Utilize cancellation over isMounted for indicators
|
Thanks ^_^ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsMounted is going to be deprecated and as facebook guys clearly express, it's an anti-pattern.
Closes #1626 and #2354
A part of #2573 umbrella issue.
@oliviertassinari Take a look 😁