Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress components don't cancel setTimeouts when they unmount #1626

Closed
matgr1 opened this issue Sep 11, 2015 · 1 comment · Fixed by #2739
Closed

progress components don't cancel setTimeouts when they unmount #1626

matgr1 opened this issue Sep 11, 2015 · 1 comment · Fixed by #2739
Labels
bug 🐛 Something doesn't work performance

Comments

@matgr1
Copy link

matgr1 commented Sep 11, 2015

just looking through the code (and based on what I'm seeing while running), componentDidMount for at least circula-progress and linear-progress don't cancel the setTimeouts that they do... which means whenever you add a progress component this will be looping forever

@chrismcv
Copy link
Contributor

something like this might be a nice pattern
https://github.com/Khan/react-components/blob/master/js/set-interval-mixin.jsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants