Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser support without bundler/browserify #483

Closed
wants to merge 1 commit into from

Conversation

bill-min
Copy link
Contributor

@bill-min bill-min commented Oct 2, 2024

Check issue here: browserify/node-util#62

It throws error process is not defined if bundler does not handle it when used in browser.

@mtth
Copy link
Owner

mtth commented Oct 3, 2024

avsc historically didn't support browser builds without a bundler. This would be a reasonable feature request, but we should do it cleanly (e.g. remove bundler related files and configurations).

@bill-min
Copy link
Contributor Author

bill-min commented Oct 3, 2024

If you check the node-util issue, ppl already complained that vite/webpack5/esbuild doesn't polyfill process anymore, which is what most ppl use nowadays. Its kinda weird that util sits under browserify but named node-util while the maintainer doesn't want to support browser compatibility at all...

@bill-min
Copy link
Contributor Author

bill-min commented Oct 4, 2024

Let me know what you think @mtth, I am happy to tweak the PR and/or refactor properly if we are aiming for the fix.

@mtth
Copy link
Owner

mtth commented Oct 7, 2024

I'm leaning towards removing debuglog altogether - would you mind updating the PR (types.js and the 2 platform.js files)?

@bill-min
Copy link
Contributor Author

bill-min commented Oct 7, 2024

#486

@bill-min bill-min closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants