Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process is not defined in browser #484

Closed
bill-min opened this issue Oct 2, 2024 · 3 comments
Closed

process is not defined in browser #484

bill-min opened this issue Oct 2, 2024 · 3 comments

Comments

@bill-min
Copy link
Contributor

bill-min commented Oct 2, 2024

Issue when import avro from "avsc/etc/browser/avsc-types";.

#486

I think there are many ways to resolve the issue, but the key is not to use util when in browser.

@mtth
Copy link
Owner

mtth commented Oct 3, 2024

Which bundler are you using?

@bill-min
Copy link
Contributor Author

bill-min commented Oct 3, 2024

Its customized stuff and I am using esbuild for one use case. I don't really like the fix personally, but seems like most straightforward change, if we are going to refactoring this lib to use esm and latest stuff anyway. One other way is to use util-browser instead of util when require from /etc/browser, but you are going to add one more dependency.

@mtth
Copy link
Owner

mtth commented Oct 9, 2024

Resolved in #486.

@mtth mtth closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants