Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5925 test mail connection #5994

Merged
merged 5 commits into from
Jan 10, 2025
Merged

5925 test mail connection #5994

merged 5 commits into from
Jan 10, 2025

Conversation

lache-melvin
Copy link
Contributor

Fixes #5925

πŸ‘©πŸ»β€πŸ’» What does this PR do?

Adds mail test connection step to test_connection tool

πŸ’Œ Any notes for the reviewer?

πŸ§ͺ Testing

  • With no mail settings in local.yaml - passes with message saying "only required on central"
  • With mail settings present - errors - could not get connection
  • Start mailhog and re-run - succeeds

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the V2.5.0-RC2 milestone Jan 10, 2025
@mark-prins mark-prins self-assigned this Jan 10, 2025
Copy link
Collaborator

@mark-prins mark-prins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚒 love it!
a :nit re the docs - tested and working nicely though πŸ™

server/README.md Outdated Show resolved Hide resolved
Co-authored-by: Mark Prins <9192912+mark-prins@users.noreply.github.com>
@lache-melvin lache-melvin merged commit 0e31c27 into V2.5.0-RC Jan 10, 2025
@lache-melvin lache-melvin deleted the 5925-test-mail-connection branch January 10, 2025 03:47
@lache-melvin
Copy link
Contributor Author

Adding the step was very nice and easy to write! Thanks for the effort on the tool, cleaning up the steps πŸ”₯

@roxy-dao roxy-dao modified the milestones: V2.5.0-RC3, v2.5.0 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants