Add generating with customer_name_id #5958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
fergie-nz
commented
Jan 8, 2025
Comment on lines
207
to
211
| let customer_name_id = StoreRowRepository::new(connection) | ||
| .find_one_by_id(&ctx.user_id.clone())? | ||
| .ok_or(RepositoryError::NotFound)? | ||
| .name_link_id; | ||
|
|
There was a problem hiding this comment.
To ensure merge safety, I'm not entirely clear on if we should be using name_link_id or querying the store repository to find the name_row.id.
fergie-nz
added
Severity: Hotfix
jmbrunskill
reviewed
Jan 9, 2025
server/service/src/requisition/request_requisition/insert_program.rs
Outdated
Show resolved
Hide resolved
roxy-dao
requested changes
Jan 9, 2025
server/service/src/requisition/request_requisition/insert_program.rs
Outdated
Show resolved
Hide resolved
roxy-dao
reviewed
Jan 9, 2025
server/service/src/requisition/response_requisition/insert_program.rs
Outdated
Show resolved
Hide resolved
Search for name id rather thank link id and search for store correctly
This was referenced Jan 10, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5951
👩🏻💻 What does this PR do?
Fixes to use customer store name id rather than other party (which could be the supplier) store name id for indicator values.
💌 Any notes for the reviewer?
I was struggling to get tests working with time available and removed them here. I wonder if worthwhile adding these in and including tests to cover correct assignment of store_id, name_id, etc.
🧪 Testing