Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indicator values are saving customer_name_id as other_party_name_id #5951

Closed
fergie-nz opened this issue Jan 8, 2025 · 2 comments · Fixed by #5958
Closed

indicator values are saving customer_name_id as other_party_name_id #5951

fergie-nz opened this issue Jan 8, 2025 · 2 comments · Fixed by #5958
Assignees
Labels
bug Something is borken Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. Team Ruru 🦉 Andrei, Roxy, Ferg
Milestone

Comments

@fergie-nz
Copy link
Contributor

What went wrong? 😲

Indicator values are saving customer_name_id as other_party_name_id
Where they are created as internal orders, the customer_name_id is saved as the supplying store name id.

Expected behaviour 🤔

customer_name_id should always refer to the customer.

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Create indicator values for a program internal order
  2. See the customer_name_id refers to the supplying store name

Your environment 🌱

  • Open mSupply Version:
  • Legacy mSupply Central Server Version:
  • Platform:
  • Database type:
@fergie-nz fergie-nz added bug Something is borken needs triage needs daily triage New bug to be triaged by the release team labels Jan 8, 2025
@fergie-nz fergie-nz self-assigned this Jan 8, 2025
@andreievg andreievg added Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. and removed needs triage needs daily triage New bug to be triaged by the release team labels Jan 8, 2025
@andreievg
Copy link
Collaborator

This one should be done as hotfix since data that is stored is inconsistent with the mSupply

@roxy-dao roxy-dao added this to the V2.5.0-RC2 milestone Jan 9, 2025
@roxy-dao roxy-dao added the Team Ruru 🦉 Andrei, Roxy, Ferg label Jan 9, 2025
@roxy-dao
Copy link
Contributor

roxy-dao commented Jan 9, 2025

Closed by #5958

@roxy-dao roxy-dao closed this as completed Jan 9, 2025
@roxy-dao roxy-dao modified the milestones: V2.5.0-RC2, v2.5.0 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. Team Ruru 🦉 Andrei, Roxy, Ferg
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants