Skip to content
This repository has been archived by the owner on Jun 30, 2020. It is now read-only.

Instantiate module & Hover fix #17

Closed
wants to merge 8 commits into from
Closed

Conversation

Yushiao
Copy link
Contributor

@Yushiao Yushiao commented Mar 26, 2017

Hi~

I make a command that can instantiate 2001-style verilog module (sorry for only 2001-style)

Usage:

  1. Open command palette Ctrl+Shift+P and type System Verilog: Instantiate Module
  2. Choose file you want to instantiate
  3. It will insert inst at cursor location

By the way, I update the hover function that not show the last , and ; now

@bjaminn
Copy link
Contributor

bjaminn commented Mar 26, 2017

Looks like good work. Would there be a way to add an example of the instantiation in the README.md? I could do it after the request gets accepted if not.

@mshr-h
Copy link
Owner

mshr-h commented Mar 27, 2017

Thanks for new feature and bugfix.

It looks good to me.
But sending bugfix / new feature / package config update / travis-ci config update in the same PR is messed-up.
So, please split into multiple PRs.

@Yushiao
Copy link
Contributor Author

Yushiao commented Mar 27, 2017

@bjaminn I think @mshr-h will update README.md and version numbers after the PR is merged

@mshr-h OK, I will split this PR to 3 PRs

  1. package config update / travis-ci config update
  2. hover bugfix
  3. instantiate module

@Yushiao Yushiao closed this Mar 27, 2017
This was referenced Mar 27, 2017
@Yushiao Yushiao deleted the inst-module branch March 27, 2017 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants