-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Move NodeMaterial to JSM. #16917
Conversation
All of the places you used this look OK to me, but just for future reference, I would avoid using this shorthand (even for long lists of imports) within the |
Awesome! Is the intent still to transform the examples/jsm/Nodes folder into a single file in examples/js/Nodes? If so I can help modify the |
That would be my thought, and it probably applies to at least |
I would say yes. After finalizing |
I'll look into proposing some changes to |
@Mugen87 Thanks! 👏 👏 👏 |
Thanks! |
Follow up of #16054
Note: In some example I'm using this pattern similar to the
THREE
import:Otherwise there is an extreme long list of imports.
/cc @sunag