-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] JSM: Move nodes/* #16054
[WIP] JSM: Move nodes/* #16054
Conversation
@donmccurdy Very niceee, thanks! Leveraging the subject my doubts about ES modules... Is there any demarcation today that would prevent we advance in |
I think that |
I'd be fine with using ES6 Classes in the |
Because this PR is still a WIP? I think is important merge for add futures updates. |
I will finish this PR soon. 👍 After that, whatever you prefer on ES6 Classes is OK with me. |
Hm, I'm not sure I can convert (a) modify I think I prefer (b), but it requires #15599 or something similar. Maybe that can be simplified a bit; I'll comment there. |
The postprocessing classes are now available as modules 😇 . |
@donmccurdy Do you think you are able to finish this PR in the next time 😇? The node material files and the related examples are one of the last todos in our JSM/module task list, see #16688 BTW: It could make sense to start from scratch since many things changed in the last weeks. If you are busy with other stuff, I can do this, too. |
All files in
examples/js/nodes/*
were already ES modules. This PR moves them to thejsm/
folder, adds imports from the main threejs library, and fixes a few strayTHREE.*Node
references that needed to be imports. With that, it should be possible to import them in the same way as otherjsm/
examples:I've only fixed the first two examples, and will fix the remaining five if we want to proceed with this PR. Note that I've removed the original
js/
files, because this change was not fully automated, and it probably isn't worth the effort to do so./cc @sunag