Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch over circular dep between Box3 and Sphere #10547

Merged
merged 2 commits into from
Jan 12, 2017
Merged

Patch over circular dep between Box3 and Sphere #10547

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cde08b
Allow lazy loading of the Box3 constructor, so that webpack can load …
chazcb Jan 9, 2017
9c88b59
Update to explicitly check for undefined box value, add PR ID for dis…
chazcb Jan 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/math/Sphere.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ Sphere.prototype = {

setFromPoints: function () {

var box = new Box3();
var box;

return function setFromPoints( points, optionalCenter ) {

box = box || new Box3();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can add here a comment like box = box || new Box3(); // see #10547

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also do...

if ( box === undefined ) box = new Box3();

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prevent circular references all the time using this pattern. Why the inline comment in this case?


var center = this.center;

if ( optionalCenter !== undefined ) {
Expand Down