Patch over circular dep between Box3 and Sphere #10547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…three js source files directly instead of requiring all of the THREE.
chazcb
changed the title
Mugen87
reviewed
Jan 10, 2017
|
|
||
| return function setFromPoints( points, optionalCenter ) { | ||
|
|
||
| box = box || new Box3(); |
There was a problem hiding this comment.
Maybe you can add here a comment like box = box || new Box3(); // see #10547
There was a problem hiding this comment.
I would also do...
if ( box === undefined ) box = new Box3();
There was a problem hiding this comment.
We prevent circular references all the time using this pattern. Why the inline comment in this case?
…cussion reference.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Box3 relies on Sphere, and Sphere relies on Box3 to instantiate an instance of Box3 and use that instance's methods inside
setFromPoints. This is a fairly naive patch to resolve the circular dependency so that we can load three.js source files using webpack / babel.