Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Support Windows #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions src/io/github/sirlantis/rubymine/rubocop/RubocopTask.kt
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,13 @@ import com.intellij.openapi.module.Module
import java.io.Closeable
import java.io.BufferedInputStream
import com.intellij.openapi.application.Application
import com.intellij.openapi.util.SystemInfo
import org.jetbrains.plugins.ruby.ruby.run.RunnerUtil
import io.github.sirlantis.rubymine.rubocop.utils.NotifyUtil
import org.jetbrains.plugins.ruby.gem.GemUtil
import org.jetbrains.plugins.ruby.gem.util.BundlerUtil
import org.jetbrains.plugins.ruby.gem.util.GemSearchUtil
import org.jetbrains.plugins.ruby.ruby.sdk.RubySdkAdditionalData

class RubocopTask(val module: Module, val paths: List<String>) : Task.Backgroundable(module.project, "Running RuboCop", true) {

Expand All @@ -40,6 +43,14 @@ class RubocopTask(val module: Module, val paths: List<String>) : Task.Background
sdk?.homeDirectory?.parent?.canonicalPath
}

val installedInSdk: Boolean by lazy {
GemSearchUtil.findGem(sdk, "rubocop") != null
}

val installedInBundle: Boolean by lazy {
GemSearchUtil.findGem(module, "rubocop") != null
}

override fun run(indicator: ProgressIndicator) {
run()
}
Expand All @@ -52,7 +63,7 @@ class RubocopTask(val module: Module, val paths: List<String>) : Task.Background
return
}

if (GemSearchUtil.findGem(module, "rubocop") == null) {
if (!installedInSdk && !installedInBundle) {
logger.warn("Didn't find rubocop gem")
return
}
Expand Down Expand Up @@ -157,16 +168,25 @@ class RubocopTask(val module: Module, val paths: List<String>) : Task.Background
fun runViaCommandLine(sdk: Sdk) {
val runner = RunnerUtil.getRunner(sdk, module)

val commandLineList = linkedListOf("rubocop", "--format", "json")
val rubocopPath = GemUtil.getGemExecutableRubyScriptPath(module, sdk, "rubocop",
"rubocop")!!
val commandLineList = linkedListOf(rubocopPath, "--format", "json")
commandLineList.addAll(paths)

val command = commandLineList.removeFirst()
val command = if (SystemInfo.isWindows && sdk.sdkAdditionalData is RubySdkAdditionalData) {
(sdk.sdkAdditionalData as RubySdkAdditionalData).getInterpreterPath(sdk)
} else {
commandLineList.removeFirst()
}
val args = commandLineList.toTypedArray()
val sudo = false

val commandLine = runner.createAndSetupCmdLine(workDirectory.canonicalPath!!, null, true, command, sdk, sudo, *args)
val preprocessor = BundlerUtil.createBundlerPreprocessor(module, sdk)
preprocessor.preprocess(commandLine)

if (installedInBundle) {
val preprocessor = BundlerUtil.createBundlerPreprocessor(module, sdk)
preprocessor.preprocess(commandLine)
}

logger.debug("Executing RuboCop (SDK=%s)".format(sdkRoot), commandLine.commandLineString)

Expand Down