Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Support Windows #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support Windows #39

wants to merge 2 commits into from

Conversation

lowjoel
Copy link

@lowjoel lowjoel commented Feb 18, 2016

This properly #9 and #32.

The first commit fixes #24.

This allows the use of system/user-installed Rubocop.
…unning Rubocop.

This also uses the full path to the Rubocop gem.
@johnthagen
Copy link

@lowjoel Since this PR has not been merged and released, would you mind sharing the build steps in order to build this fork? I'm just trying to get the plugin .jar so that I can use it in RubyMine.

My current configuration is:

  • Download your support-windows PR
  • Open project with IntelliJ Community 15.0.4 (143.1184.17)
  • Kotlin Plugin 1.0.0-release-IJ143-70 is installed
  • Point Module SDK at RubyMine 8.0.3 (143.1559.2) install folder
  • Make Project
Information:Kotlin: Kotlin JPS plugin version 1.0.0-release-IJ143-70
Information:Kotlin: Plugin loaded: KotlinAndroidJpsPlugin
Information:Kotlin: Using kotlin-home = C:\Users\John Hagen\.IdeaIC15\config\plugins\Kotlin\kotlinc
Information:Kotlin: Kotlin Compiler version 1.0.0
Information:3/8/2016 8:15 PM - Compilation completed with 2 errors and 0 warnings in 2s 996ms
C:\Users\John Hagen\IdeaProjects\rubocop-for-rubymine-support-windows\src\io\github\sirlantis\rubymine\rubocop\RubocopTask.kt
Error:(173, 31) Kotlin: Unresolved reference: linkedListOf
C:\Users\John Hagen\IdeaProjects\rubocop-for-rubymine-support-windows\src\io\github\sirlantis\rubymine\rubocop\model\RubocopResult.kt
Error:(54, 24) Kotlin: Unresolved reference: linkedListOf

@johnthagen
Copy link

@lowjoel I was actually able to get it to build with the above confirguration after a bit of work. My fork is here: https://github.com/johnthagen/rubocop-for-rubymine

@lowjoel
Copy link
Author

lowjoel commented Mar 10, 2016

That was a change in the newest Kotlin version; I didn't want to include that commit here because I didn't touch that bit of code (AFAIK), so I would rather wait for @sirlantis to commit that fix separately.

@CyberStrike
Copy link

Until this merged I've compiled an unofficial release of this PR.

Rubocop For Rubymine 3.1.0.a

@andrewtch
Copy link

Can we merge this somehow? )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support user-installed gems
4 participants