Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add mqtt 5 beta banner and sponsors section #1617

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Jun 27, 2023

Also did a quick lint fix on readme

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4869f1e) 86.22% compared to head (0b5e78d) 86.22%.

❗ Current head 0b5e78d differs from pull request most recent head ca76bf9. Consider uploading reports for the commit ca76bf9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1617   +/-   ##
=======================================
  Coverage   86.22%   86.22%           
=======================================
  Files          13       13           
  Lines        1314     1314           
=======================================
  Hits         1133     1133           
  Misses        181      181           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

vishnureddy17
vishnureddy17 previously approved these changes Jun 27, 2023
README.md Outdated Show resolved Hide resolved
Co-authored-by: Vishnu Reddy <vishnureddy@microsoft.com>
@robertsLando
Copy link
Member Author

cc @mcollina just to inform you, a sponsor section has been added to project README

@robertsLando
Copy link
Member Author

Tests are flaky, hopefully #1534 will fix this

@robertsLando robertsLando merged commit a170c54 into main Jun 27, 2023
3 of 4 checks passed
@robertsLando robertsLando deleted the docs-update branch June 27, 2023 15:55
@robertsLando
Copy link
Member Author

@vishnureddy17 FYI I tried to make a new beta release using the workflow. It went well except for the last step where it should push the release and changelog to main branch: https://github.com/mqttjs/MQTT.js/actions/runs/5409237552/jobs/9829130699#step:7:1054

I will see if/how I can fix this

@robertsLando
Copy link
Member Author

OK seems the only way would be to use a personal access token sectet. In this way we can skip the branch protection checks. The secrets.GITHUB_TOKEN that is actually used in the workflow is a temporary token created for that workflow run and has not the right access for pushing the release commit/tag to main branch.

In order to do this you should go to mqttjs org and add a personal access token (let's name it GH_TOKEN) and then I can use it here. I would use a fine grained token so it has access only to this repo and has only the required permissions.

Let me know if you can do that. otherwise that action cannot be used for now, not a big deal BTW as I just have to run a command in my end to do the same but could be handy in future to trigger releases from there :)

@vishnureddy17
Copy link
Member

I just gave you permissions to the organization, does that work?

@robertsLando
Copy link
Member Author

I saw the email, will give that a look tomorrow. Thanks!

robertsLando added a commit that referenced this pull request Jun 30, 2023
Co-authored-by: Vishnu Reddy <vishnureddy@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants