-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: drop support for node 12-14 #1615
Conversation
BREAKING CHANGE: Droppend support for NodeJS 12 and 14
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1615 +/- ##
=======================================
Coverage 86.22% 86.22%
=======================================
Files 13 13
Lines 1314 1314
=======================================
Hits 1133 1133
Misses 181 181 ☔ View full report in Codecov by Sentry. |
Is there anything else I should do to drop the support? |
Pretty sure that's it. |
@robertsLando Since this is a breaking change, I think we should take this opportunity to see if there's any other breaking changes we want to make before the next release. One thing I have in mind is removing the WeChat specific stuff, I do not think it belongs in this. |
I will give a check to that, what about creating a beta for now? Just to check if the release process works |
Yep that sounds good. |
Should I remove the |
Yep, but it doesn't have to be in this test beta release unless you want to do it now :) I think there are references to it in the Readme that would have to be removed also |
Yeah I'm checking them now there are many references around the code. What's the reason you want to drop that support? |
It's not a standard transport protocol and it's instead specific to a proprietary product. I don't think that belongs in an open source project.
Yeah, that's the problem, the proprietary stuff has seeped into lots of areas in the code, which I think is a mistake. However, this library doesn't have support for custom transports, so maybe we have to tolerate this or add support for custom transport. |
Yeah that's what I wanted to point out, I mean without a custom transport support all users using that protocol would have no alternatives |
Done: https://github.com/mqttjs/MQTT.js/releases/tag/v5.0.0-beta.0 Also available on NPM with |
@vishnureddy17 If that is ok I would wait to merge some other PR marked with |
Yes, I agree with waiting on those PRs, there is no rush To inform users I think replying to this GitHub issue would be a good idea, since there might be interested parties that are subscribed to that issue. Also maybe add a temporary announcement somewhere near the top of the README. |
Hey @robertsLando thank you for the dedication and work! Its great to see that you picked it up and try to manage/maintain mqtt.js! I want just make a suggestion. Have you think about Github Sponsors for MQTT.js library? https://github.com/sponsors Just to make it sustainable, the time and effort of the team to contribute to this library. I believe MQTT.js should setup github sponsors so it can accept donations. After all time is precious and I remember this tweet from Matteo Collina - https://twitter.com/matteocollina/status/1083322337292890112?lang=en And I would suggest to also add the beta release note at the top of the README (temporarily) So its the first that users see that a v5 beta to test is available when they open the repository and scroll to the readme |
Hi @BearCooder, I already use GH sponsors in all my projects and I think that would be a good addition for sure. Anyway the project isn't mine so I would like to know @vishnureddy17 opinion on this... how could we manage this? We could enable GH sponsor in the organization but then I dunno who could maintain that |
Couple of thoughts:
|
Maybe adding a |
I created #1617 Let me know your thoughts about that and if I should add someone to sponsors |
BREAKING CHANGE: Dropped support for NodeJS 12-14
BREAKING CHANGE: Dropped support for NodeJS 12-14