Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] How to fix "colour space conversion issue, resulting in a green tint" #11460

Closed
erickyun opened this issue Mar 15, 2023 · 9 comments
Closed

Comments

@erickyun
Copy link

erickyun commented Mar 15, 2023

Hi,

I have movie that has a "color space conversion" problem where the whole movie has green tint because of this problem.

I would appreciate if someone could please tell me what cmd -vf colorspace or colorprimaries I need to change to fix the green tint?

Source
Green Tint İssue (Sample picture from movie)

@haasn
Copy link
Member

haasn commented Mar 15, 2023

Not enough info provided

@erickyun
Copy link
Author

Not enough info provided

What else should I provide sir?

@haasn
Copy link
Member

haasn commented Mar 15, 2023

log, sample file

@erickyun
Copy link
Author

erickyun commented Mar 15, 2023

log, sample file

log.txt

sample-file.mkv.zip

@hooke007
Copy link
Contributor

It was introduced from producer instead of encoder. https://twitter.com/AnimeAjay/status/1600502670824964099

@haasn
Copy link
Member

haasn commented Mar 16, 2023

In that case, you could fix it with a shader or maybe try --vf=format:primaries=dci-p3?

@erickyun
Copy link
Author

erickyun commented Mar 17, 2023

That Worked for me thanks.

What shader would fix this? Could you please tell me sir?

Edit:
I don't know if it will be helpful sir? but some encoder said that he fixed with a proper DCI-P3 to D65 white point correction. Here his note:
Note: This release corrects the green tint issue on the source with a proper DCI-P3 to D65 white point correction.

His No Tint - 1080p HDR encode

His No Tint - x265 - 1080p encode

@NormTurtle
Copy link

@erickyun can i knwo why this issue occurs

@hooke007
Copy link
Contributor

It was explained in my previous link.

hooke007 added a commit to hooke007/MPV_lazy that referenced this issue May 9, 2023
vpy:
使用另一种导入方式;
修复个别脚本中的错误;
超分补帧类脚本统一加入预缩小处理;
移除 MEMC_RIFE_STD_LQ (与关联脚本的重合性高);
新增 MEMC_SVP_PRO 取代 MEMC_SVP_HQ

模块:
按需导入其它库;
修改初始线程数量的设置策略;
前置API检测;
对全部模块的无效参数值提供报错反馈;
多个涉及trt的模块启用长路径支持;
修复svp相关的模块无法使用cpu的问题。

- AA_NV 回退旧版,移除参数 plane
- ACNET_STD 参数 gpu_m 改变取值类型并默认为 1
- COLOR_P3W_FIX 此为新增模块,修复p3白点的特例 mpv-player/mpv#11460
- ESRGAN_NV 参数 model 新增可用值 0 ,支持v2模型
- FMT_CTRL 参数 h_max 不再可选,默认为 0
- MVT_MQ 此为新增模块,功能为通用补帧
- NNEDI3_STD 优化速度,参数 edi_nsize 更名 nsize ,参数 edi_nns 更名 nns
- RIFE_NV_ORT 此为新增模块,功能为支持N卡专属的补帧
- SVP_PRO 此为新增模块,功能为通用补帧
- UAI_NV_TRT 此模块由原模块 UAI_TRT_NV 重命名而来,原参数 model_pth 的默认值变更为 "" ;调整子参数顺序;新增参数 opt_lv 构建优化等级,默认为 3
hooke007 added a commit to hooke007/MPV_lazy that referenced this issue May 9, 2023
vpy:
使用另一种导入方式;
修复个别脚本中的错误;
超分补帧类脚本统一加入预缩小处理;
移除 MEMC_RIFE_STD_LQ (与关联脚本的重合性高);
新增 MEMC_SVP_PRO 取代 MEMC_SVP_HQ

模块:
按需导入其它库;
修改初始线程数量的设置策略;
前置API检测;
对全部模块的无效参数值提供报错反馈;
多个涉及trt的模块启用长路径支持;
修复svp相关的模块无法使用cpu的问题。

- AA_NV 回退旧版,移除参数 plane
- ACNET_STD 参数 gpu_m 改变取值类型并默认为 1
- COLOR_P3W_FIX 此为新增模块,修复p3白点的特例 mpv-player/mpv#11460
- ESRGAN_NV 参数 model 新增可用值 0 ,支持v2模型
- FMT_CTRL 参数 h_max 不再可选,默认为 0
- MVT_MQ 此为新增模块,功能为通用补帧
- NNEDI3_STD 优化速度,参数 edi_nsize 更名 nsize ,参数 edi_nns 更名 nns
- RIFE_NV_ORT 此为新增模块,功能为支持N卡专属的补帧
- SVP_PRO 此为新增模块,功能为通用补帧
- UAI_NV_TRT 此模块由原模块 UAI_TRT_NV 重命名而来,原参数 model_pth 的默认值变更为 "" ;调整子参数顺序;新增参数 opt_lv 构建优化等级,默认为 3
AClon314 pushed a commit to AClon314/mpv-config-linux that referenced this issue Jun 16, 2024
vpy:
使用另一种导入方式;
修复个别脚本中的错误;
超分补帧类脚本统一加入预缩小处理;
移除 MEMC_RIFE_STD_LQ (与关联脚本的重合性高);
新增 MEMC_SVP_PRO 取代 MEMC_SVP_HQ

模块:
按需导入其它库;
修改初始线程数量的设置策略;
前置API检测;
对全部模块的无效参数值提供报错反馈;
多个涉及trt的模块启用长路径支持;
修复svp相关的模块无法使用cpu的问题。

- AA_NV 回退旧版,移除参数 plane
- ACNET_STD 参数 gpu_m 改变取值类型并默认为 1
- COLOR_P3W_FIX 此为新增模块,修复p3白点的特例 mpv-player/mpv#11460
- ESRGAN_NV 参数 model 新增可用值 0 ,支持v2模型
- FMT_CTRL 参数 h_max 不再可选,默认为 0
- MVT_MQ 此为新增模块,功能为通用补帧
- NNEDI3_STD 优化速度,参数 edi_nsize 更名 nsize ,参数 edi_nns 更名 nns
- RIFE_NV_ORT 此为新增模块,功能为支持N卡专属的补帧
- SVP_PRO 此为新增模块,功能为通用补帧
- UAI_NV_TRT 此模块由原模块 UAI_TRT_NV 重命名而来,原参数 model_pth 的默认值变更为 "" ;调整子参数顺序;新增参数 opt_lv 构建优化等级,默认为 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants