Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed runtime.getBrowserInfo() #200

Merged
merged 2 commits into from
Aug 1, 2019
Merged

Conversation

Shubhamchinda
Copy link
Contributor

@Shubhamchinda Shubhamchinda commented Aug 1, 2019

Fixes #184

@Rob--W , Let me know if other changes are required. :)

Thanks a lot!

@@ -422,10 +404,6 @@
"minArgs": 0,
"maxArgs": 0
},
"getBrowserInfo": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change that should be kept. All other removals from this PR should be undone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh Sorry!
I've updated it.

Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@Rob--W Rob--W merged commit 3929b9f into mozilla:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime.getBrowserInfo() should not be in api-metadata.json
2 participants