Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime.getBrowserInfo() should not be in api-metadata.json #184

Closed
rafaelgomesxyz opened this issue Apr 14, 2019 · 6 comments · Fixed by #200
Closed

runtime.getBrowserInfo() should not be in api-metadata.json #184

rafaelgomesxyz opened this issue Apr 14, 2019 · 6 comments · Fixed by #200
Labels
contrib: good first bug contrib: mentor assigned

Comments

@rafaelgomesxyz
Copy link

This method is not supported on Chrome.

Apparently it was already supposed to be removed in #125?
@rafaelgomesxyz rafaelgomesxyz changed the title getBrowserInfo() should not be in api-metadata.json runtime.getBrowserInfo() should not be in api-metadata.json Apr 14, 2019
@Rob--W
Copy link
Member

Rob--W commented Apr 15, 2019

The diff in #125 shows the difference between what would be generated if only supported methods are used. The red parts of the div haven't actually been removed, but pull requests to remove them are welcome.

@caitmuenster
Copy link

Mentor: @Rob--W

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

@Shubhamchinda
Copy link
Contributor

Hey, Can I take this up?

@Rob--W
Copy link
Member

Rob--W commented Aug 1, 2019

@Shubhamchinda Sure. Let me know if you have any questions.

@Shubhamchinda Shubhamchinda mentioned this issue Aug 1, 2019
Merged
@rafaelgomesxyz
Copy link
Author

@Shubhamchinda Thanks for the fix, I never got around to doing it.

@Rob--W Is a new release coming soon? Right now I'm having to manually remove this line when using the NPM package.

@Rob--W
Copy link
Member

Rob--W commented Sep 8, 2019

I'll check whether we can create a new release, on Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib: good first bug contrib: mentor assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed runtime.getBrowserInfo() Shubhamchinda/webextension-polyfill
5 participants
@rpl @Rob--W @Shubhamchinda @caitmuenster @rafaelgomesxyz