Add web-ext submit to submit listed add-ons to AMO

[fregante]

Workaround described below ⬇️

Is this a bug or feature request?

Feature request

What is the current behavior?

web-ext sign already successfully submits an extension for review, but then it throws an error.

What is the expected or desired behavior?

I don't need instant signing, so if the submission has been successful there should be a way to make it exit with 0.

Suggestions:

$ web-ext sign --submit-only
$ web-ext submit

Version information (for bug reports)

OS X 10.11.6

node --version && npm --version && web-ext --version

v7.2.0
3.10.9
1.8.1

[kumar303]

The sign command is intended more for people who self-distribute their add-ons. In your case, why not just use the website? https://addons.mozilla.org/en-US/developers/addon/submit/distribution Is it because you need to put new versions in the review queue frequently? Or just because you'd like to automate the submission process?

[fregante]

Automate all the things! 😉 Here people discussed the Chrome Web Store version, but it also applies to AMO sindresorhus/project-ideas#66

[kumar303]

Yeah, using web-ext to automatically put a new version in the AMO review queue seems like it could be useful to support automatic deployment (from a git tag or whatever).

I think it would make sense as a new command, such as what you recommended: web-ext submit or web-ext submit-to-amo (to be explicit, maybe).

The good news is that sign-addon already wraps up the signing API pretty well. The bad news is that the API doesn't support submission of listed add-ons in a straightforward way. Using the signing API to submit a listed add-on would be a hack and I'm not sure that it would be so dependable against future API changes. The fact that it works now at all is just by side effect.

We decided to log an informative message about it in web-ext sign but we also let it throw an error to discourage usage. I guess that's a little weird though, heh.

[FranciscoG]

100% this!

I just setup some tasks to automate submitting my extension to the Chrome web store and now I'm working on Firefox (first time ever messing with Firefox Add-ons, so happy about WebExtensions). Looking through the Firefox documentation it wasn't clear to me at all that I could automate sending updates to AMO for an existing add-on... not for self-hosting/self-signing. I even just asked a question on stackoverflow about this.

[kumar303]

Even if we added a web-ext submit command, it would not be fully possible to automate submission. The addons.mozilla.org site always requires an editor to review the extension code which is different from the Chrome Store (I believe).

[fregante]

Understood. The current web-ext sign workflow is fine and it's enough for me already. The only issue is the error exit code.

It's still better than packaging it up, opening the browser, visiting AMO, uploading it, etc manually.

[FranciscoG]

agreed . I just want Travis to be able to build and send it off my extension to each respective store. I understand that there's a review process.

I guess for now I'll deal with the error.

@bfred-it are you requiring web-ext from a module? is that possible? or you using child process? Any issues installing web-ext a local dev dependency?

[fregante]

@FranciscoG I'm not, I plan on using it via npm scripts like I'm doing with chrome-webstore-upload-cli on travis

[fregante]

Workaround

I published a 11-lines, temporary web-ext wrapper that filters out the error:

npm install --global web-ext-submit
web-ext-submit

Meant to be used on Travis or GitHub Actions.

https://github.com/fregante/web-ext-submit

Alternative

Or use https://github.com/LinusU/wext-shipit

[guillaumevincent]

Hello,
automatic deployment is something really important.
Maybe web-ext submit should also allow publishing source code in zip format?

Thank you @bfred-it

[fregante]

web-ext submit would submit to amo only. If you want the zip you can already use web-ext build

[guillaumevincent]

@bfred-it you can add sources to your webextension, to help review

[fregante]

Ah I see what you mean, you have a gulp build step in place. I left a link to the repo in the notes for the reviewer before to show the source.

[fregante]

@guillaumevincent this command uses the Signing API, which only allows the upload of the extension itself. I don't see web-ext allowing the upload of the sources unless there's an API for that. Your best bet would be to include a link to your repo in the zip itself.

[kumar303]

I removed the "submit for review" part of this issue title because post-review has landed! In other words, listed add-ons are now published ASAP without needing to pass human review.

This makes something like a web-ext submit feature way more useful but I'll be honest in that we are not able to dedicate any Mozilla resources to adding this feature (as far as I know).

[antibot4navalny]

supporting add-on submission entirely through the API (which web-ext needs) will be planned for Q1 2019

Any updates to ETA on blockers for mozilla/addons-server#804 / the mozilla/addons-server#804 itself?

[sospedra]

Any help with this? I'm removing our addon from Firefox store because it's unmanageable doing manually every time 😞

[diox]

web-ext supports --channel listed argument to upload new listed versions of your add-on. It's only unsupported for the first, initial listed version of the add-on, because there is no way to submit the required metadata (categories, license, custom summary / slug, etc). But if you already have a listed version, it should work fine.

The things we're still missing are blocked on API support:

• Upload of source code and release notes Allow upload of source code (and release/reviewer notes) using the API addons#6158
• Submitting the first listed version (including required metadata) Upload/submit a new listed add-on version through the API addons#5348

Both web-ext and addons-server are opensource though, so if you want to help, those issues are the place to start.

[fregante]

Any help with this?

You can use https://github.com/fregante/web-ext-submit

[guillaumevincent]

@fregante we agree that source upload is not working yet right?

[fregante]

@fregante we agree that source upload is not working yet right?

That isn't possible at all, refer to mozilla/sign-addon#409 and mozilla/addons#6158

[eviljeff]

This was completed with #2503 (and linked issues).

[eviljeff]

@fregante we agree that source upload is not working yet right?

That isn't possible at all, refer to mozilla/sign-addon#409 and mozilla/addons#6158

#2497 will add this within web-ext - the api can be used directly in the meantime (albeit with the added hassle of crafting the auth headers, etc, yourself)

[eviljeff]

@eviljeff what is the new command/flag to replace web-ext-submit?

web-ext sign --use-submission-api - see https://extensionworkshop.com/documentation/develop/web-ext-command-reference/#setting-option-environment-variables for how some of the command line options change when --use-submission-api is specified.

And will it appear in the next version?

It's in the current version, but there are still a few outstanding pieces of work to "finish" it, such as mozilla/addons-server#2497

[fregante]

I finally got the chance to use use this API, it works!

- web-ext-submit
+ web-ext sign --use-submission-api --channel listed