Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that 'sign' can submit a listed extension for review #806

Open
Elergy opened this issue Feb 14, 2017 · 2 comments
Open

Document that 'sign' can submit a listed extension for review #806

Elergy opened this issue Feb 14, 2017 · 2 comments

Comments

@Elergy
Copy link

Elergy commented Feb 14, 2017

Is this a bug or feature request?

I'm not sure that it's a proper behavior, but if it is, we should document it.

What is the current behavior?

I run web-ext sign in the directory with listed extension's sources.
I got a message:

Your add-on has been submitted for review. It passed validation but could not be automatically signed because this is a listed add-on.
FAIL

Then my extension was submitted for review, and current position in the queue for moderation was lost.

What is the expected or desired behavior?

As a minimum, we should have a documentation that web-ext sign can submit an extension for review. Now a description looks this way:

Packages an extension and signs it so it can be self-hosted. This will create a signed .xpi file instead of a .zip file. You will need to create API access credentials to run this command.

Version information (for bug reports)

web-ext@1.8.1

@kumar303
Copy link
Contributor

Sorry about this confusing behavior :)

we should have a documentation that web-ext sign can submit an extension for review.

I'd like to discourage the usage of web-ext sign for putting listed add-ons in the AMO review queue. It only works now by side effect and I'm just worried that it could break in the future since the signing API wasn't really meant for this use case. Because of that, I'm hesitant to document it.

I think it's pretty clear that we need to create a new command for submitting listed add-ons to AMO.

@fregante
Copy link
Contributor

Sweet! Yeah a new command would be great, as long as web-ext retains the functionality ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants