Simplify the ColorSpaceUtils.singletons handling (PR 19564 follow-up)
#19607
+56
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
ColorSpaceUtils-rm-singletons
branch
from
2701aa6 to
87d5367
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/627abde770a514e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/627abde770a514e/output.txt Total script time: 29.51 mins
|
calixteman
reviewed
Mar 5, 2025
With the changes in PR 19564 the actual `ColorSpace`-classes where separated from the various static "helper" methods. Hence it seems that we can now simplify/shorten this old code to instead cache the "standard" ColorSpaces directly on the `ColorSpaceUtils`-class.
Snuffleupagus
force-pushed
the
ColorSpaceUtils-rm-singletons
branch
from
87d5367 to
d8d7235
Compare
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4266afda098d15e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4266afda098d15e/output.txt Total script time: 16.63 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes in PR #19564 the actual
ColorSpace-classes where separated from the various static "helper" methods.Hence it seems that we can now simplify/shorten this old code to instead cache the "standard" ColorSpaces directly on the
ColorSpaceUtils-class.