[api-minor] Support using ICC profiles in using qcms (bug 860023) #19564

calixteman · 2025-02-26T22:19:14Z

No description provided.

calixteman · 2025-02-26T22:19:30Z

/botio test

moz-tools-bot · 2025-02-26T22:19:33Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/265341b40e3ee6f/output.txt

moz-tools-bot · 2025-02-26T22:19:33Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b0bf3a5b07533fb/output.txt

moz-tools-bot · 2025-02-26T22:49:42Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b0bf3a5b07533fb/output.txt

Total script time: 30.14 mins

Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 215

Image differences available at: http://54.241.84.105:8877/b0bf3a5b07533fb/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2025-02-26T23:20:07Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/265341b40e3ee6f/output.txt

Total script time: 60.01 mins

Snuffleupagus · 2025-02-27T07:56:57Z

The Node.js test failures can probably be fixed by adding a line for qcms, similar to:

pdf.js/gulpfile.mjs

Line 1658 in da17c7b

gulp.src("external/openjpeg/*.js", { base: "openjpeg/", encoding: false }),

Looking at the Linux reference tests there's bunch of small movement (invisible to the naked eye), or changes that are obvious improvements (when comparing with Adobe Reader), however there's also two actual regressions:

issue5939-page1
kdchart-page1

Snuffleupagus

Leaving a few unsolicited questions/comments, despite this still being a draft.

external/qcms/qcms_pdf_js.js

eslint.config.mjs

external/qcms/qcms_pdf_js.js

src/core/colorspace_utils.js

external/qcms/qcms_pdf_js_bg.wasm

calixteman · 2025-02-27T21:25:27Z

@Snuffleupagus would you know how to fix the generic build ?

Snuffleupagus · 2025-02-27T21:27:59Z

would you know how to fix the generic build ?

If you mean the CI tests, did you try what I suggested in #19564 (comment)?

Snuffleupagus · 2025-02-27T21:53:45Z

It seems to me that the lib gulp build-target might have trouble with the wasm_utils.js file being imported from both the external/qcms/ and src/core/ folders, could we perhaps place that file in external/qcms/ instead (or is that not appropriate)?

Headcrabed · 2025-02-28T03:18:52Z

Btw we still have some issues in firefox's color management implementation:
https://bugzilla.mozilla.org/show_bug.cgi?id=1939259
https://bugzilla.mozilla.org/show_bug.cgi?id=1834978

calixteman · 2025-02-28T13:49:43Z

Btw we still have some issues in firefox's color management implementation: https://bugzilla.mozilla.org/show_bug.cgi?id=1939259 https://bugzilla.mozilla.org/show_bug.cgi?id=1834978

It's an other problem, right ?
This patch aims to use the ICC profile provide by the pdf file instead of fallbacking on either an alternate colorspace or on a default one which is completely wrong.

external/qcms/LICENSE_QCMS

src/core/icc_colorspace.js

src/core/colorspace_utils.js

external/qcms/LICENSE_PDFJ_QCMS

Snuffleupagus

r=me, with the comments addressed and passing tests; thank you!

src/core/colorspace_utils.js

calixteman · 2025-03-04T22:01:25Z

/botio test

moz-tools-bot · 2025-03-04T22:01:28Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8ec172afe88985c/output.txt

moz-tools-bot · 2025-03-04T22:01:28Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/71ad65285a42988/output.txt

moz-tools-bot · 2025-03-04T22:31:24Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/71ad65285a42988/output.txt

Total script time: 29.91 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 215

Image differences available at: http://54.241.84.105:8877/71ad65285a42988/reftest-analyzer.html#web=eq.log

Snuffleupagus

Unfortunately it seems that kdchart-page1 is still failing.

calixteman · 2025-03-05T08:52:06Z

/botio test

moz-tools-bot · 2025-03-05T08:52:09Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3eb16a8a26cad6c/output.txt

moz-tools-bot · 2025-03-05T09:21:29Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/3eb16a8a26cad6c/output.txt

Total script time: 29.31 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 215

Image differences available at: http://54.241.84.105:8877/3eb16a8a26cad6c/reftest-analyzer.html#web=eq.log

Snuffleupagus

r=me, thank you.

calixteman · 2025-03-05T09:34:32Z

/botio makeref

moz-tools-bot · 2025-03-05T09:34:34Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6aa53488fc66111/output.txt

moz-tools-bot · 2025-03-05T09:51:16Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/6aa53488fc66111/output.txt

Total script time: 16.68 mins

Make references: Passed
Check references: Passed

Snuffleupagus added core image-quality release-blocker Blocker for the upcoming release labels Feb 26, 2025

Snuffleupagus reviewed Feb 27, 2025

View reviewed changes

Snuffleupagus added the image-conversion label Feb 27, 2025

Snuffleupagus linked an issue Feb 27, 2025 that may be closed by this pull request

ICC profiles support for images #2856

Closed

calixteman force-pushed the qcms_icc branch 3 times, most recently from 7d50496 to 14ee30a Compare February 27, 2025 21:19

calixteman force-pushed the qcms_icc branch from 14ee30a to 0b50af1 Compare February 27, 2025 21:36

calixteman force-pushed the qcms_icc branch 2 times, most recently from 135efc8 to 5dad49b Compare February 28, 2025 15:26

calixteman marked this pull request as ready for review February 28, 2025 15:48

calixteman requested a review from Snuffleupagus February 28, 2025 15:48

calixteman force-pushed the qcms_icc branch from 5dad49b to c51a4e6 Compare February 28, 2025 15:53

calixteman changed the title ~~Support using ICC profiles in using qcms~~ Support using ICC profiles in using qcms (bug 860023) Feb 28, 2025

Snuffleupagus reviewed Feb 28, 2025

View reviewed changes

external/qcms/LICENSE_QCMS Outdated Show resolved Hide resolved

src/core/icc_colorspace.js Outdated Show resolved Hide resolved

src/core/colorspace_utils.js Outdated Show resolved Hide resolved

external/qcms/LICENSE_PDFJ_QCMS Outdated Show resolved Hide resolved

Snuffleupagus changed the title ~~Support using ICC profiles in using qcms (bug 860023)~~ [api-minor] Support using ICC profiles in using qcms (bug 860023) Feb 28, 2025

calixteman force-pushed the qcms_icc branch from c51a4e6 to 720b879 Compare March 3, 2025 17:57

Snuffleupagus approved these changes Mar 3, 2025

View reviewed changes

src/core/colorspace_utils.js Outdated Show resolved Hide resolved

src/core/colorspace_utils.js Outdated Show resolved Hide resolved

src/core/colorspace_utils.js Show resolved Hide resolved

calixteman force-pushed the qcms_icc branch from 720b879 to 53fc899 Compare March 4, 2025 20:23

Snuffleupagus requested changes Mar 4, 2025

View reviewed changes

calixteman force-pushed the qcms_icc branch from 53fc899 to 5658e63 Compare March 5, 2025 08:40

Snuffleupagus approved these changes Mar 5, 2025

View reviewed changes

Support using ICC profiles in using qcms (bug 860023)

971be48

calixteman force-pushed the qcms_icc branch from 5658e63 to 971be48 Compare March 5, 2025 09:30

calixteman merged commit 19bc5dc into mozilla:master Mar 5, 2025
9 checks passed

This was referenced Mar 5, 2025

Simplify the ColorSpaceUtils.singletons handling (PR 19564 follow-up) #19607

Merged

Version 5 release checklist #19536

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[api-minor] Support using ICC profiles in using qcms (bug 860023) #19564

[api-minor] Support using ICC profiles in using qcms (bug 860023) #19564

calixteman commented Feb 26, 2025

calixteman commented Feb 26, 2025

moz-tools-bot commented Feb 26, 2025

moz-tools-bot commented Feb 26, 2025

moz-tools-bot commented Feb 26, 2025

moz-tools-bot commented Feb 26, 2025

Snuffleupagus commented Feb 27, 2025

Snuffleupagus left a comment

calixteman commented Feb 27, 2025

Snuffleupagus commented Feb 27, 2025

Snuffleupagus commented Feb 27, 2025 •

edited

Loading

Headcrabed commented Feb 28, 2025

calixteman commented Feb 28, 2025

Snuffleupagus left a comment

calixteman commented Mar 4, 2025

moz-tools-bot commented Mar 4, 2025

moz-tools-bot commented Mar 4, 2025

moz-tools-bot commented Mar 4, 2025

Snuffleupagus left a comment •

edited

Loading

calixteman commented Mar 5, 2025

moz-tools-bot commented Mar 5, 2025

moz-tools-bot commented Mar 5, 2025

Snuffleupagus left a comment

calixteman commented Mar 5, 2025

moz-tools-bot commented Mar 5, 2025

moz-tools-bot commented Mar 5, 2025

[api-minor] Support using ICC profiles in using qcms (bug 860023) #19564

[api-minor] Support using ICC profiles in using qcms (bug 860023) #19564

Conversation

calixteman commented Feb 26, 2025

calixteman commented Feb 26, 2025

moz-tools-bot commented Feb 26, 2025

From: Bot.io (Windows)

Received

moz-tools-bot commented Feb 26, 2025

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Feb 26, 2025

From: Bot.io (Linux m4)

Failed

moz-tools-bot commented Feb 26, 2025

From: Bot.io (Windows)

Failed

Snuffleupagus commented Feb 27, 2025

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented Feb 27, 2025

Snuffleupagus commented Feb 27, 2025

Snuffleupagus commented Feb 27, 2025 • edited Loading

Headcrabed commented Feb 28, 2025

calixteman commented Feb 28, 2025

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented Mar 4, 2025

moz-tools-bot commented Mar 4, 2025

From: Bot.io (Windows)

Received

moz-tools-bot commented Mar 4, 2025

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Mar 4, 2025

From: Bot.io (Linux m4)

Failed

Snuffleupagus left a comment • edited Loading

Choose a reason for hiding this comment

calixteman commented Mar 5, 2025

moz-tools-bot commented Mar 5, 2025

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Mar 5, 2025

From: Bot.io (Linux m4)

Failed

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented Mar 5, 2025

moz-tools-bot commented Mar 5, 2025

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Mar 5, 2025

From: Bot.io (Linux m4)

Success

Snuffleupagus commented Feb 27, 2025 •

edited

Loading

Snuffleupagus left a comment •

edited

Loading