-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to the most recent versions and upgrade eslint-plugin-unicorn
to version 54.0.0
#18278
Conversation
eslint-plugin-unicorn
to version 54.0.0
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cd0608f94ae4552/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/cd0608f94ae4552/output.txt Total script time: 1.18 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 2 Live output at: http://54.193.163.58:8877/fc40754fda086b5/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/65b7373d235b3e2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/65b7373d235b3e2/output.txt Total script time: 27.02 mins
Image differences available at: http://54.241.84.105:8877/65b7373d235b3e2/reftest-analyzer.html#web=eq.log |
I'm not really sure what's wrong with Chrome here: it looks like it just... stopped halfway the integration tests? I do recall having seen such weird high number of errors before, and it was usually just a one-time fluke. I'll rebase and retry it later. |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/fc40754fda086b5/output.txt Total script time: 43.46 mins
Image differences available at: http://54.193.163.58:8877/fc40754fda086b5/reftest-analyzer.html#web=eq.log |
This is a major version bump, but the changelog at https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v54.0.0 doesn't indicate any breaking changes that should impact us.
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e760630018db0d7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e760630018db0d7/output.txt Total script time: 28.79 mins
Image differences available at: http://54.241.84.105:8877/e760630018db0d7/reftest-analyzer.html#web=eq.log |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/64a9d44e17dee7a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/64a9d44e17dee7a/output.txt Total script time: 1.07 mins Published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/de62e4d6937f0f9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/d56d77caf086036/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/de62e4d6937f0f9/output.txt Total script time: 20.09 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/d56d77caf086036/output.txt Total script time: 24.52 mins
|
The commit messages contain more details about the individual changes. Notes for the reviewer:
eslint-plugin-jasmine
update contains support for ESLint 9 (see https://github.com/tlvince/eslint-plugin-jasmine/releases/tag/v4.2.0), which brings us another step closer for Upgradeeslint
to version 9.0.0 #17928.@metalsmith/markdown
update is interesting because that one should already have been part of Replace Wintersmith with Metalsmith #18248. I don't know what happened exactly, but I somehow managed to mess up the version number there and probably copy/pasted the older one.puppeteer
update contains some bugfixes and Chrome updates that could benefit us (see https://github.com/puppeteer/puppeteer/releases), but note that this version does not yet contain the fix for chromium-bidi does not handle exceptions when logging GoogleChromeLabs/chromium-bidi#2317 because even though it's released thechromium-bidi
bump has not been done in the Puppeteer repository yet. (This one was identified in Use WebDriver BiDi for Chrome #17961 (comment) and could help us get more details as to what's going wrong in the Chrome-on-BiDi PR.)