Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium-bidi does not handle exceptions when logging #2317

Closed
OrKoN opened this issue Jun 14, 2024 · 1 comment · Fixed by #2323
Closed

chromium-bidi does not handle exceptions when logging #2317

OrKoN opened this issue Jun 14, 2024 · 1 comment · Fixed by #2323
Labels
bug Something isn't working

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Jun 14, 2024

TEST-PASSED | gets operatorList, with page resources containing corrupt /CCITTFaxDecode data | in chrome
file:///C:/pdfjs/botio-files-pdfjs/private/a53e51e62057105/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:69
            this._reject(callback, new TargetCloseError('Target closed'));
                                   ^

TargetCloseError: Protocol error (Runtime.callFunctionOn): Target closed
    at CallbackRegistry.clear (file:///C:/pdfjs/botio-files-pdfjs/private/a53e51e62057105/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:69:36)
    at CdpCDPSession._onClosed (file:///C:/pdfjs/botio-files-pdfjs/private/a53e51e62057105/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/CDPSession.js:98:25)
    at Connection.onMessage (file:///C:/pdfjs/botio-files-pdfjs/private/a53e51e62057105/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/Connection.js:126:25)
    at WebSocket.<anonymous> (file:///C:/pdfjs/botio-files-pdfjs/private/a53e51e62057105/node_modules/puppeteer-core/lib/esm/puppeteer/node/NodeWebSocketTransport.js:38:32)
    at callListener (C:\pdfjs\botio-files-pdfjs\private\a53e51e62057105\node_modules\ws\lib\event-target.js:290:14)
    at WebSocket.onMessage (C:\pdfjs\botio-files-pdfjs\private\a53e51e62057105\node_modules\ws\lib\event-target.js:209:9)
    at WebSocket.emit (node:events:519:28)
    at Receiver.receiverOnMessage (C:\pdfjs\botio-files-pdfjs\private\a53e51e62057105\node_modules\ws\lib\websocket.js:1209:20)
    at Receiver.emit (node:events:519:28)
    at Immediate.<anonymous> (C:\pdfjs\botio-files-pdfjs\private\a53e51e62057105\node_modules\ws\lib\receiver.js:599:16) {
  cause: ProtocolError
      at <instance_members_initializer> (file:///C:/pdfjs/botio-files-pdfjs/private/a53e51e62057105/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:89:14)
      at new Callback (file:///C:/pdfjs/botio-files-pdfjs/private/a53e51e62057105/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:93:16)
      at CallbackRegistry.create (file:///C:/pdfjs/botio-files-pdfjs/private/a53e51e62057105/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:19:26)
      at Connection._rawSend (file:///C:/pdfjs/botio-files-pdfjs/private/a53e51e62057105/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/Connection.js:85:26)
      at CdpCDPSession.send (file:///C:/pdfjs/botio-files-pdfjs/private/a53e51e62057105/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/CDPSession.js:63:33)
      at CDPClientAdapter.sendCommand (file:///C:/pdfjs/botio-files-pdfjs/private/a53e51e62057105/node_modules/puppeteer-core/lib/esm/puppeteer/bidi/BidiOverCdp.js:106:39)
      at WorkerRealm.serializeCdpObject (C:\pdfjs\botio-files-pdfjs\private\a53e51e62057105\node_modules\chromium-bidi\lib\cjs\bidiMapper\modules\script\Realm.js:153:47)
      at C:\pdfjs\botio-files-pdfjs\private\a53e51e62057105\node_modules\chromium-bidi\lib\cjs\bidiMapper\modules\log\LogManager.js:64:38
      at Array.map (<anonymous>)
      at C:\pdfjs\botio-files-pdfjs\private\a53e51e62057105\node_modules\chromium-bidi\lib\cjs\bidiMapper\modules\log\LogManager.js:63:45
}

See mozilla/pdf.js#17961 (comment)

@OrKoN OrKoN added the bug Something isn't working label Jun 14, 2024
@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 14, 2024

cc @sadym-chromium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant