Don't display annotations with a PMD (barcode stuff) entry (bug 1899804) #18228
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/376cb1dc0e44e48/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e1aadf07ecb2255/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e1aadf07ecb2255/output.txt Total script time: 36.68 mins
Image differences available at: http://54.241.84.105:8877/e1aadf07ecb2255/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/376cb1dc0e44e48/output.txt Total script time: 50.01 mins
Image differences available at: http://54.193.163.58:8877/376cb1dc0e44e48/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Looks good to me with the comment addressed. Looking at https://tex.stackexchange.com/a/439478 and the fact that I also can't find anything about PMD or the /PaperMetaData type, it seems safe to say that this is a proprietary Acrobat feature and not something we can support, so I agree that hiding it seems best.
There was a problem hiding this comment.
r=me, with passing tests and the comment below addressed. This solution is now also similar to what we had before at https://github.com/mozilla/pdf.js/pull/13214/files#diff-a7e409abd3d3209d32d3adc8457c5e23feb4c06113a2e065b0c6a9322a3a3369L1155-L1162 (but better because setFlags wiped the existing flags from an API perspective whereas this patch keeps them correctly, and barcodes don't have a field value so we don't need to unset it). Thank you!
There's no specification for that (even if it's possible to have an idea from the xfa specs) so we just want to hide them in order to avoid to display something wrong.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ede1faf896fa873/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a9bd07abb70afed/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a9bd07abb70afed/output.txt Total script time: 28.37 mins
Image differences available at: http://54.241.84.105:8877/a9bd07abb70afed/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ede1faf896fa873/output.txt Total script time: 42.00 mins
Image differences available at: http://54.193.163.58:8877/ede1faf896fa873/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c93e48ddeda55db/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/339c782241ba313/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c93e48ddeda55db/output.txt Total script time: 19.67 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/339c782241ba313/output.txt Total script time: 24.71 mins
|
There's no specification for that (even if it's possible to have an idea from the xfa specs) so we just want to hide them in order to avoid to display something wrong.