Skip to content

Commit

Permalink
Don't display annotations with a PMD (barcode stuff) entry (bug 1899804)
Browse files Browse the repository at this point in the history
There's no specification for that (even if it's possible to have an idea from
the xfa specs) so we just want to hide them in order to avoid to display something
wrong.
  • Loading branch information
calixteman committed Jun 10, 2024
1 parent bb73d2a commit e3faa40
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 2 deletions.
12 changes: 10 additions & 2 deletions src/core/annotation.js
Original file line number Diff line number Diff line change
Expand Up @@ -2681,11 +2681,19 @@ class TextWidgetAnnotation extends WidgetAnnotation {
constructor(params) {
super(params);

const { dict } = params;

if (dict.has("PMD")) {
// It's used to display a barcode but it isn't specified so we just hide
// it to avoid any confusion.
this.flags |= AnnotationFlag.HIDDEN;
this.data.hidden = true;
warn("Barcodes are not supported");
}

this.data.hasOwnCanvas = this.data.readOnly && !this.data.noHTML;
this._hasText = true;

const dict = params.dict;

// The field value is always a string.
if (typeof this.data.fieldValue !== "string") {
this.data.fieldValue = "";
Expand Down
1 change: 1 addition & 0 deletions test/pdfs/bug1899804.pdf.link
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://bugzilla.mozilla.org/attachment.cgi?id=9406437
17 changes: 17 additions & 0 deletions test/test_manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -10064,5 +10064,22 @@
"rounds": 1,
"link": true,
"type": "eq"
},
{
"id": "bug1899804_print",
"file": "pdfs/bug1899804.pdf",
"md5": "53d82575d6d5d314404ede8970073e1b",
"rounds": 1,
"link": true,
"type": "eq",
"print": true
},
{
"id": "bug1899804",
"file": "pdfs/bug1899804.pdf",
"md5": "53d82575d6d5d314404ede8970073e1b",
"rounds": 1,
"link": true,
"type": "eq"
}
]

0 comments on commit e3faa40

Please sign in to comment.