Remove strikethrough as an option for rich text #15503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Struck-through text does not end up as editable at our l10n vendor's side of things, which means localization breaks for any page containing it. We don't use it anyway, so better to avoid it being sent over altogether. The migration is needed because it describes the state of the page model that already has a rich-text field in it, and we just changed that state by removing a formatting option. Resolves #15498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Struck-through text does not end up as editable at our l10n vendor's side of things, which means localization breaks for any page containing it.
We don't use it anyway, so better to avoid it being sent over altogether.
The migration is needed because it describes the state of the page model that already has a rich-text field in it, and we just changed that state by removing a formatting option.
Resolves #15498