Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strikethrough is not supported in Smartling #15498

Closed
Tracked by #14225
stevejalim opened this issue Nov 14, 2024 · 1 comment · Fixed by #15503
Closed
Tracked by #14225

Strikethrough is not supported in Smartling #15498

stevejalim opened this issue Nov 14, 2024 · 1 comment · Fixed by #15503
Assignees
@stevejalim

Comments

@stevejalim
Copy link
Collaborator

When rich text containing a strikethrough is sent to Smartling, it is not editable/translateable

This may be wagtail-localize or it might be Smartling, but either way we should disable the option in Wagtail's rich-text editor - we don't use it at the moment, so there won't be any loss

@alexgibson - sound OK to you?
@stevejalim stevejalim self-assigned this Nov 14, 2024
@stevejalim stevejalim mentioned this issue Nov 14, 2024
Open
@alexgibson
Copy link
Member

@stevejalim this sounds sensible to me yeah. I can't imagine many use-cases for needing it in CMS content.

stevejalim added a commit that referenced this issue Nov 15, 2024
@stevejalim
Remove strikethrough as an option for rich text
2211b6b 
Struck-through text does not end up as editable at our l10n vendor's side of
things, which means localization breaks for any page containing it.

We don't use it anyway, so better to avoid it being sent over altogether.

The migration is needed because it describes the state of the page model
that already has a rich-text field in it, and we just changed that state
by removing a formatting option.

Resolves #15498
@stevejalim stevejalim mentioned this issue Nov 15, 2024
Merged
stevejalim added a commit that referenced this issue Nov 15, 2024
@stevejalim
Remove strikethrough as an option for rich text (#15503)
0ca1f34 
Struck-through text does not end up as editable at our l10n vendor's side of
things, which means localization breaks for any page containing it.

We don't use it anyway, so better to avoid it being sent over altogether.

The migration is needed because it describes the state of the page model
that already has a rich-text field in it, and we just changed that state
by removing a formatting option.

Resolves #15498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevejalim stevejalim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove strikethrough as an option for rich text mozilla/bedrock
2 participants
@stevejalim @alexgibson