Move ReleaseNotes.notes from being a custom NotesField #14582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14582 +/- ##
=======================================
Coverage 76.44% 76.45%
=======================================
Files 148 148
Lines 7987 7986 -1
=======================================
Hits 6106 6106
+ Misses 1881 1880 -1 ☔ View full report in Codecov by Sentry. |
robhudson
approved these changes
May 17, 2024
|
Ooh I should amend the revised migration to match |
robhudson
reviewed
May 17, 2024
…SONField so we can loaddata into it This is precursor work to moving to sqlite while retaining an export-to-sqlite route. Editing the migration seems OK, given NotesField was a subclass of JSONField with no schema-related changes.
stevejalim
force-pushed
the
14574-refactor-notes-field
branch
from
00896b3 to
cd08d27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to a simpler JSONField so we can loaddata into it
This is precursor work to moving to sqlite while retaining an export-to-sqlite route.
Editing the migration seems OK, given NotesField was a subclass of JSONField with no schema-related changes.
Issue / Bugzilla link
Resolves #14574
Testing