Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minorly refactor ProductRelease.notes field #14574

Closed
2 tasks
stevejalim opened this issue May 15, 2024 · 0 comments · Fixed by #14582
Closed
2 tasks

Minorly refactor ProductRelease.notes field #14574

stevejalim opened this issue May 15, 2024 · 0 comments · Fixed by #14582
Assignees
@stevejalim

Comments

@stevejalim
Copy link
Collaborator

Description

We have a notes field in ProductRelease which automatically converts the JSON in the DB column to a list of Python objects.

This is convenient in many situations, but when we're exporting a database (as we'll need to do for the Wagtail work) this automatic hydration of objects cauases loaddata to blow up.

We can refactor to make the field un-clever and instead of calling somerelease.notes we instead call somerelease.get_notes and move the behaviour into that method.

Success Criteria

  • Release notes pages are 100% unaffected, and show all their relevant notes
  • There's no automatic behaviour on the notes field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevejalim stevejalim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move ReleaseNotes.notes from being a custom NotesField mozilla/bedrock
1 participant
@stevejalim