-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download pybind11 via CMake instead of shipping it #86
Conversation
Will also update pybind to version 2.10.0 and should fix #68. |
I think that ultimately, it would be good if we could set the pybind version as an option. That way, if someone depends on a particular pybind version, it is easier to fix. Not urgent though. Otherwise: LGTM and many thanks |
One can already define the version in |
As it currently must be the same as pycarls version, does it make sense to take the pycarl version as default? |
The recent changes allow to set the pybind version to use. As default we are using the pybind version exported by pycarl (see moves-rwth/pycarl#15). Note that this requires to import pycarl during the build process and pycarl was added to |
Tests are currently failing, because moves-rwth/pycarl#15 is not used yet. |
LGTM |
Download pybind11 in the configure step such that it is available for
add_subdirectory
.Should best be merged simultaneous to the similar PR in pycarl moves-rwth/pycarl#15.