Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Pybind version #81

Closed
sjunges opened this issue Aug 2, 2022 · 3 comments
Closed

Check Pybind version #81

sjunges opened this issue Aug 2, 2022 · 3 comments

Comments

@sjunges
Copy link
Contributor

sjunges commented Aug 2, 2022

Based on a discussion in moves-rwth/pycarl#15 (comment) we should check the PyBind11 version that pycarl uses and compare it to the one we are using for stormpy. While it may work without issue, at least providing a warning may be essential to prevent strange errors.

@volkm
Copy link
Contributor

volkm commented Aug 3, 2022

I fully agree.
The technical question is how to get the pybind version? While pybind has the variable pybind11_VERSION (see here), using add_subdirectory opens a new scope such that one cannot access this variable from outside.
One possibility might be to use find_package which needs an installation of pybind though.
Or we build a python function which accesses the version information available in pybind11.h. However, in that case the check can only be performed after compilation is finished.

@sjunges
Copy link
Contributor Author

sjunges commented Sep 1, 2022

See also #86

@volkm
Copy link
Contributor

volkm commented Sep 14, 2022

The check was integrated by PR #86.

@volkm volkm closed this as completed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants