-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port controller_manager submodule of moveit_core to ROS 2 #6
Port controller_manager submodule of moveit_core to ROS 2 #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the controller manager will still need a replacement for ros::Duration in the waitForExecution method but I assume you will take care of that later on
that's right, I believe @anasarrak was looking at this aspect this morning. We'll send a PR once it's ready I guess. |
* | ||
* The controller is expected to execute the trajectory, but this function call should not block. | ||
* Blocking is achievable by calling waitForExecution(). | ||
* Return false when the controller cannot accept the trajectory. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regression in commenting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anasarrak can you please review this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* set robot state positions/velocities/accelerations from ruckig outout * updated file name for ruckig traj smoothing * added plugin for ruckig trajectory smoothing * removed extra space * added ruckig to file name and update authors * deleted unnesessary lines Co-authored-by: Wyatt Rees <wyatt.rees@gmail.com>
* set robot state positions/velocities/accelerations from ruckig outout * updated file name for ruckig traj smoothing * added plugin for ruckig trajectory smoothing * removed extra space * added ruckig to file name and update authors * deleted unnesessary lines Co-authored-by: Wyatt Rees <wyatt.rees@gmail.com>
* set robot state positions/velocities/accelerations from ruckig outout * updated file name for ruckig traj smoothing * added plugin for ruckig trajectory smoothing * removed extra space * added ruckig to file name and update authors * deleted unnesessary lines Co-authored-by: Wyatt Rees <wyatt.rees@gmail.com>
* Install hybrid_planning_demo_node separately to avoid exporting it * Fix exported include directory * Remove getTargetWayPointIndex() from abstract trajectory operator class * Delete unused getTargetWayPointIndex()
Fix kdl joint weights and update our branch from main
No description provided.