Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of Fanuc model misspelling #870

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Correction of Fanuc model misspelling #870

merged 10 commits into from
Nov 27, 2024

Conversation

Carbyne
Copy link
Contributor

@Carbyne Carbyne commented Nov 26, 2024

Description

There is a mistake in the spelling of some FANUC robot arm models, LRMate is mispelled as IRMate in the robot overview. This pull request fixes the issue.

Checklist

  • Tested modified webpage locally using the build_locally.sh script

Copy link
Contributor

@simonschmeisser simonschmeisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your correction is a good improvement but I would suggest to use the official names

robots/index.markdown Outdated Show resolved Hide resolved
@Carbyne
Copy link
Contributor Author

Carbyne commented Nov 27, 2024

Should be ready for merge now.

It seems there are some inconsistencies between the MoveIt robots overview and the supported robot URDFs in the fanuc meta-package that need to be sorted out:

In both MoveIt overview and fanuc package:
m10ia_macro.xacro
lrmate200ib3l_macro.xacro
lrmate200ib_macro.xacro
lrmate200ic5h_macro.xacro
lrmate200ic5l_macro.xacro
lrmate200ic_macro.xacro
m16ib20_macro.xacro
m20ia10l_macro.xacro
m20ia_macro.xacro
m20ib25_macro.xacro
m430ia2f_macro.xacro
m430ia2p_macro.xacro
m6ib_macro.xacro
cr7ia_macro.xacro
cr7ial_macro.xacro

In fanuc package, not in MoveIt overview:
cr35ia_macro.xacro
lrmate200ic5f_macro.xacro
lrmate200ic5hs_macro.xacro
lrmate200id4s_macro.xacro
lrmate200id4sc_macro.xacro
lrmate200id4sh_macro.xacro
lrmate200id7h_macro.xacro
lrmate200id7l_macro.xacro
lrmate200id7lc_macro.xacro
m10ia7l_macro.xacro
m6ib6s_macro.xacro
m710ic45m_macro.xacro
m710ic50_macro.xacro
m900ia260l_macro.xacro
m900ib700_macro.xacro
r1000ia80f_macro.xacro
lrmate200i_macro.xacro

In MoveIt overview, not in fanuc package:
m16ib_macro.xacro
m430ia_macro.xacro

@simonschmeisser
Copy link
Contributor

In MoveIt overview, not in fanuc package: m16ib_macro.xacro m430ia_macro.xacro

I would suggest to just drop these two (they both have entries for specific models of the "series") and keep it low effort

@rhaschke rhaschke merged commit 7574cb1 into moveit:main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants