Updates to ActionKit, Braintree, and S3 connectors #754
Conversation
Update setup_google_application_credentials to support dict parameter
…egation The oauth2client library is deprecated, and gspread will drop most information from the oauth2client authorization. Switch to the actively maintained google-auth library and add an argument for a delegated account name.
Update authorization library for Google Sheets to support account del…
Update authorization library for Google Sheets to support account delegation
Don't auto-grab session token if it's not passed in
The new method paginated_get expands get_events to work for any type of object, and get_events has been updated to refer to paginated_get. In addition, a new method, paginated_get_custom_limit, allows for truncating the data based on the value of a field, rather than a fixed set of results. For example, this would allow you to return all users created within the last day. (Some fields which permit ordering may not permit filtering, which is why this can't be accomplished with a simple filter.) Tests have also been written for the new methods. Names of methods and arguments are not final and could use some work; suggestions welcome.
Modeled on transaction search. Test data obtained by editing the subscription gateway to print the search response (https://github.com/braintree/braintree_python/blob/fc98c738f9e74736a7d1e82cfb4e37f6e493c3c4/braintree/subscription_gateway.py#L59).
Add subscription search to Braintree
Add new general object search methods to ActionKit
Update from upstream branch
|
This looks good to me. I'm okay with approving/merging now, but I'd be a bit more comfortable if someone familiar with these connectors also reviewed. @schuyler1d, if you have the time can you take a look? |
There was a problem hiding this comment.
fwiw, I'd call @crayolakat the expert (e.g.I believe she did the early braintree implementation)
I had one comment/question, but I believe it's just fixing a bug in the documentation (might be worth checking the api -- there are some weird edges)
| @@ -186,28 +185,12 @@ def get_events(self, limit=None, **kwargs): | |||
|
|
|||
| .. code-block:: python | |||
|
|
|||
| ak.get_events(fields__name__contains="FirstName") | |||
| ak.get_events(name__contains="FirstName") | |||
There was a problem hiding this comment.
Is this backwards-incompatible or was the doc just incorrect?
There was a problem hiding this comment.
I think this is fixing the documentation but not sure. Tagging @sjwmoveon since she's the author of this change.
There was a problem hiding this comment.
Yes, the documentation was incorrect.
There was a problem hiding this comment.
okay, great. I'm going to go ahead and approve + merge this. thanks for the contribution @sjwmoveon and @crayolakat and thanks for the review @schuyler1d
Congregate improvements to the ActionKit, Braintree, and S3 connectors