Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription search to Braintree #19

Merged
merged 11 commits into from
Aug 26, 2022
Merged

Add subscription search to Braintree #19

merged 11 commits into from
Aug 26, 2022

Conversation

sjwmoveon
Copy link

Modeled on transaction search. Test data obtained by editing the subscription gateway to print the search response (https://github.com/braintree/braintree_python/blob/fc98c738f9e74736a7d1e82cfb4e37f6e493c3c4/braintree/subscription_gateway.py#L59).

crayolakat and others added 11 commits March 22, 2022 14:34
Update setup_google_application_credentials to support dict parameter
…egation

The oauth2client library is deprecated, and gspread will drop most information from the oauth2client authorization.  Switch to the actively maintained google-auth library and add an argument for a delegated account name.
Update authorization library for Google Sheets to support account del…
Update authorization library for Google Sheets to support account delegation
Modeled on transaction search.  Test data obtained by editing the subscription gateway to print the search response (https://github.com/braintree/braintree_python/blob/fc98c738f9e74736a7d1e82cfb4e37f6e493c3c4/braintree/subscription_gateway.py#L59).
@sjwmoveon sjwmoveon requested a review from nilatti August 24, 2022 22:27
Copy link

@nilatti nilatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Sometime we should talk about how you ended up generating that XML. Seems useful.

@sjwmoveon
Copy link
Author

Sure! Like I said in the description, the XML gets returned in the HTTP response from Braintree, so I just had to capture it. I found the base request happens at https://github.com/braintree/braintree_python/blob/fc98c738f9e74736a7d1e82cfb4e37f6e493c3c4/braintree/subscription_gateway.py#L59 and added logging.

@sjwmoveon sjwmoveon merged commit 24ea3cb into moveon Aug 26, 2022
@sjwmoveon sjwmoveon deleted the braintree_subs branch August 26, 2022 17:58
@sjwmoveon sjwmoveon restored the braintree_subs branch September 6, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants