Support for VS2019 #343
Support for VS2019 #343
Conversation
|
Hi! I was planning to do this by reusing a subset of workarounds that are enabled by the If you enable the above option on your side, does everything compile cleanly or is there extra work needed to be done? |
| @@ -488,7 +488,7 @@ template<class ...Types> ResourceManager<Types...>*& ResourceManagerInlineInstan | |||
| } | |||
|
|
|||
| template<class T> void safeDelete(T* data) { | |||
| static_assert(sizeof(T) > 0, "Cannot delete pointer to incomplete type"); | |||
| //static_assert(sizeof(T) > 0, "Cannot delete pointer to incomplete type"); | |||
There was a problem hiding this comment.
TODO: don't forget to fix this properly!
|
Yup, if I set |
|
It's on my list for #340, so I'm going to look at it very soon one way or another. Can you live with the MSVC2017 option enabled for now? Most of those are real workarounds for nonstandard compiler behavior and I'd rather keep them explicit to avoid them being reverted by accident. I still hope that at some point in the future there would be no need for such flags, but it's still not there yet unfortunately. |
|
Sure thing, I can live with the VS17 workarounds. Thanks |
|
For the record, MSVC 2019 support is now done with mosra/corrade@161c9e0, ddb16f6, 9e2a111 and d542e2b 🎉 |
Hi, this PR fixes compilation on VS19.
There is also a problem with "Cannot delete pointer to incomplete type" that I'm not sure how to fix.