Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(safe-transfer-lib): check for code #629

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix(safe-transfer-lib): check for code #629

merged 2 commits into from
Dec 5, 2023

Conversation

Rubilmax
Copy link
Contributor

@Rubilmax Rubilmax commented Dec 5, 2023 •
edited by MerlinEgalite
Loading

@Rubilmax Rubilmax marked this pull request as ready for review December 5, 2023 09:42
QGarchery
QGarchery approved these changes Dec 5, 2023
View reviewed changes
test/forge/BaseTest.sol Outdated Show resolved Hide resolved
@MerlinEgalite MerlinEgalite merged commit 9346293 into post-cantina Dec 5, 2023
15 checks passed
@MerlinEgalite MerlinEgalite deleted the fix/issue-5 branch December 5, 2023 16:54
@MathisGD MathisGD mentioned this pull request Dec 11, 2023
Merged
@Rubilmax Rubilmax mentioned this pull request Dec 18, 2023
Merged
@StErMi
Copy link

StErMi commented Dec 20, 2023

@MerlinEgalite what's the use case to allow the creation of a market that has a non-existing (yet) loanToken or collateralToken (address(token).code.length == 0)

@MerlinEgalite
Copy link
Contributor

@MerlinEgalite what's the use case to allow the creation of a market that has a non-existing (yet) loanToken or collateralToken (address(token).code.length == 0)

for the collateral token there's one: create idle markets with all parameters set to 0 except the loan token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StErMi StErMi StErMi left review comments

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@adhusson adhusson adhusson approved these changes

@QGarchery QGarchery QGarchery approved these changes

@MathisGD MathisGD MathisGD approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

Assignees

@Rubilmax Rubilmax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Rubilmax @StErMi @MerlinEgalite @adhusson @QGarchery @MathisGD @Jean-Grimal