Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morpho blue #1

Merged
merged 13 commits into from
Jan 16, 2024
Merged

Morpho blue #1

merged 13 commits into from
Jan 16, 2024

Conversation

shriyatyagii
Copy link
Member

@shriyatyagii shriyatyagii commented Dec 16, 2023

  • Added Morpho blue contracts

Test results
image

Copy link

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are closing a final audit on morpho-blue which makes us introduce changes to the codebase, that you can find on branch morpho-blue/post-cantina
Sorry to not have warned you earlier, but if you copy all libraries from branch main then you end up using code that does not correspond to the code audited by the last audit

So I'd recommend copying the content of these libraries from branch post-cantina, ideally end of the week to make sure we've merged everything and don't copy libraries that you don't use, to make sure you don't have dead and/or outdated code in your repo
You also have the option to forge install morpho-org/morpho-blue!

A non-exhaustive list of outdated copied library is:

  • SafeTransferLib
  • SharesMathLib

contracts/mainnet/connectors/morpho-blue/events.sol Outdated Show resolved Hide resolved
contracts/mainnet/connectors/morpho-blue/helpers.sol Outdated Show resolved Hide resolved
contracts/mainnet/connectors/morpho-blue/helpers.sol Outdated Show resolved Hide resolved
@shriyatyagii
Copy link
Member Author

shriyatyagii commented Dec 19, 2023

Sure @Rubilmax
I'll update the libraries whenever all the audit changes are done. Do give a green flag whenever it's done.

@shriyatyagii
Copy link
Member Author

Add connector details -

@shriyatyagii shriyatyagii merged commit cd5aa7c into main Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants